From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8523B7C for ; Mon, 28 Mar 2022 16:08:48 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 1A8463201DA2; Mon, 28 Mar 2022 12:08:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 28 Mar 2022 12:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=animalcreek.com; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=RK/wz/U+TabQb++KAzGvfQskuMllPD dsm08D4cpJkec=; b=NVcWj4wjAMrHacgiBm0vLytCFKNuNB3EDWcOA9dEJnpVJX XUkbpoHf993ZhGBi/hPPtyuwS2Xh7wt28+EgW9ak1iZE60RFl50CPO4LNmuE5aw0 eIHWweithGeR6iAVZ+Bb7Z4WkPIZRj1LqCkM/VNjtL9/Ew4xIY/1+gkYfkWACO8G w5w1sdzav9MhNkPT5dyCijrkC2DgThazAy6385aJfaFWnrJT6Eyrrq4oDFyACRyA YPardJDVkFMmIhQpzfSWmrJnnHHUc7r1CRiVBrTmJsr9julV/6fIdYCA4LKdMt5C ywH/yE+BVJrxMjb9a9TdpHJL8B99pTefwRz2nqCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=RK/wz/U+TabQb++KA zGvfQskuMllPDdsm08D4cpJkec=; b=JPRaQHr1SDfv3tKuhbsVliljiAw+86tp/ WXOZDWvDJoxGFxxFKOq3cIZVK/3eA2nVDrUM8gGJinU4m4vlOfvlghK1/oFPCLE4 j3rkeZvZc2DowwnnnOlkFo8ngQS+u4N14KfeN4ouAyHWVZ6KCF3xpQQMdLIFNypV d/pqExLEerd+mOGVG27cNgIryKI9ADOHZAOELBSQNy3DH8JvV7qTraArCae8AzbA mNPhxd8kZ/Rfs8uadtnAaGDNXd+7HZd6YxpzysTjNQCix2Tg4WLrwcpLKGNCb61l ld4JLJhy+3YRxcGRP9v+uoJe0MpwijIIFd+r3gHVrRF8WGraSNYyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehjedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjohesthdtredttddtvdenucfhrhhomhepofgrrhhk ucfirhgvvghruceomhhgrhgvvghrsegrnhhimhgrlhgtrhgvvghkrdgtohhmqeenucggtf frrghtthgvrhhnpeeiuefguddtfeeitddvffetudefvdejhefgveevfedugfejffegieet teejudffhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmghhrvggvrhesrghnihhmrghltghrvggvkhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Mar 2022 12:08:44 -0400 (EDT) Received: by blue.animalcreek.com (Postfix, from userid 1000) id B7F8313601FE; Mon, 28 Mar 2022 09:08:43 -0700 (MST) Date: Mon, 28 Mar 2022 09:08:43 -0700 From: Mark Greer To: Dan Carpenter Cc: Xiaomeng Tong , vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] greybus: audio_codec: fix three missing initializers for data Message-ID: <20220328160843.GA262674@animalcreek.com> References: <20220327060120.4316-1-xiam0nd.tong@gmail.com> <20220328141944.GT3293@kadam> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328141944.GT3293@kadam> Organization: Animal Creek Technologies, Inc. On Mon, Mar 28, 2022 at 05:19:45PM +0300, Dan Carpenter wrote: > On Sun, Mar 27, 2022 at 02:01:20PM +0800, Xiaomeng Tong wrote: > > These three bugs are here: > > struct gbaudio_data_connection *data; > > > > If the list '&codec->module_list' is empty then the 'data' will > > keep unchanged. > > All three of these functions check for if the codec->module_list is > empty at the start of the function so these are not real bugs. Umm, yep, oops. Thanks Dan. Mark --