From: Dan Carpenter <dan.carpenter@oracle.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Date: Tue, 29 Mar 2022 14:26:44 +0300 [thread overview]
Message-ID: <20220329112644.GA3293@kadam> (raw)
In-Reply-To: <1648551967-23627-1-git-send-email-baihaowen@meizu.com>
On Tue, Mar 29, 2022 at 07:06:06PM +0800, Haowen Bai wrote:
> @@ -534,9 +531,6 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
> free_mlme_ext:
> free_mlme_ext_priv(&padapter->mlmeextpriv);
>
> -free_mlme_priv:
> - rtw_free_mlme_priv(&padapter->mlmepriv);
No, we still need to free this on error.
regards,
dan carpenter
prev parent reply other threads:[~2022-03-29 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:43 [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable Haowen Bai
2022-03-28 8:47 ` Greg KH
2022-03-28 9:07 ` 答复: " 白浩文
2022-03-28 9:12 ` Greg KH
2022-03-29 9:59 ` baihaowen
2022-03-29 11:06 ` [PATCH] " Haowen Bai
2022-03-29 11:09 ` [PATCH V3] " Haowen Bai
2022-03-29 11:28 ` Dan Carpenter
2022-03-30 1:14 ` baihaowen
2022-03-30 1:28 ` [PATCH V4] " Haowen Bai
2022-03-30 7:20 ` Dan Carpenter
2022-03-29 11:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329112644.GA3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=baihaowen@meizu.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).