From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Alaa Mohamed' <eng.alaamohamedsoliman.am@gmail.com>,
"outreachy@lists.linux.dev" <outreachy@lists.linux.dev>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects
Date: Thu, 31 Mar 2022 13:40:12 +0300 [thread overview]
Message-ID: <20220331104012.GM3293@kadam> (raw)
In-Reply-To: <ebbc4a14c30f492f8553e6ef572bbcbe@AcuMS.aculab.com>
On Thu, Mar 31, 2022 at 10:29:04AM +0000, David Laight wrote:
> From: Alaa Mohamed
> > Sent: 31 March 2022 11:19
> >
> > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro
> > reported by checkpatch
> > "CHECK: Macro argument reuse 'gdm' - possible side-effects?"
> >
> > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > ---
> > drivers/staging/gdm724x/gdm_tty.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 04df6f9f5403..6f0274470e69 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -27,7 +27,9 @@
> >
> > #define MUX_TX_MAX_SIZE 2048
> >
> > -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> > +#define GDM_TTY_READY(_gdm) \
> > + ({ typeof(_gdm) (gdm) = (_gdm); \
> > + (gdm && gdm->tty_dev && gdm->port.count); })
>
> Did you test this?
>
> see https://godbolt.org/z/cazPrrzPv
>
I don't understand the link. The patch should work as far as I can see.
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-31 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 10:18 [PATCH] staging: gdm724x: Fix Duplication of Side Effects Alaa Mohamed
2022-03-31 10:27 ` Dan Carpenter
2022-03-31 10:29 ` David Laight
2022-03-31 10:40 ` Dan Carpenter [this message]
2022-03-31 10:49 ` David Laight
2022-03-31 11:00 ` Dan Carpenter
2022-03-31 11:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331104012.GM3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@ACULAB.COM \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).