From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8723bs: place constants on the right side of tests
Date: Thu, 31 Mar 2022 17:14:56 +0300 [thread overview]
Message-ID: <20220331141456.GP3293@kadam> (raw)
In-Reply-To: <20220331122618.GA434796@euclid>
On Thu, Mar 31, 2022 at 08:26:18AM -0400, Sevinj Aghayeva wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
> ---
>
> v1 -> v2: Missed one case of constant being placed on the left. Now
> checkpath reports no such warnings for this file.
You need to send a reply to the original email "Hi, please ignore this
one, I spotted another line I want to clean up" so that Greg does not
apply it first before reading this one.
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-31 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 12:26 [PATCH v2] staging: rtl8723bs: place constants on the right side of tests Sevinj Aghayeva
2022-03-31 14:14 ` Dan Carpenter [this message]
2022-03-31 14:27 ` Sevinj Aghayeva
2022-03-31 15:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331141456.GP3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sevinj.aghayeva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).