From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label
Date: Mon, 4 Apr 2022 12:59:57 +0300 [thread overview]
Message-ID: <20220404095957.GW3293@kadam> (raw)
In-Reply-To: <YkdjhGtMwnbJcz+P@iweiny-desk3>
On Fri, Apr 01, 2022 at 01:41:40PM -0700, Ira Weiny wrote:
> On Fri, Apr 01, 2022 at 08:35:13PM +0200, Fabio M. De Francesco wrote:
> > In function rtw_free_netdev() there are two "goto" jumps to a no-op exit
> > label called "RETURN". Remove the label and return in line.
>
> Thanks for the patch! However, A good commit message lists the why and what of
> a change. I don't see a why for this commit?
People, stop belly aching about commit messages.
"Delete no-op goto" is sufficient justification.
regards,
dan carpenter
prev parent reply other threads:[~2022-04-04 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 18:35 [PATCH] staging: r8188eu: Remove goto to no-op exit label Fabio M. De Francesco
2022-04-01 20:41 ` Ira Weiny
2022-04-02 10:13 ` Fabio M. De Francesco
2022-04-02 11:45 ` Martin Kaiser
2022-04-02 13:22 ` Fabio M. De Francesco
2022-04-04 9:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404095957.GW3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).