From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8712: remove blank line after brace {
Date: Mon, 4 Apr 2022 15:51:54 +0300 [thread overview]
Message-ID: <20220404125153.GA3293@kadam> (raw)
In-Reply-To: <8c88829f625f9847a1db18fe467399594dacb064.1648902188.git.eng.alaamohamedsoliman.am@gmail.com>
On Sat, Apr 02, 2022 at 02:28:16PM +0200, Alaa Mohamed wrote:
> Fix " CHECK: Blank lines aren't necessary after an open brace '{' "
> Reported by checkpatch
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_xmit.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 84a22eba7ebf..05ba0ca7d627 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -147,7 +147,7 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe)
> }
>
> static struct xmit_frame *dequeue_one_xmitframe(struct xmit_priv *pxmitpriv,
> - struct hw_xmit *phwxmit,
> + struct hw_xmit *phwxmit,
> struct tx_servq *ptxservq,
> struct __queue *pframe_queue)
> {
Try be more aware of the surrounding code.
regards,
dan carpenter
prev parent reply other threads:[~2022-04-04 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 12:28 [PATCH 1/2] staging: rtl8712: remove blank line after brace { Alaa Mohamed
2022-04-02 12:28 ` [PATCH 2/2] staging: rtl8712: Fix Lines shouldn't end with '(' Alaa Mohamed
2022-04-03 8:57 ` Greg KH
2022-04-02 16:49 ` [PATCH 1/2] staging: rtl8712: remove blank line after brace { Larry Finger
2022-04-04 12:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404125153.GA3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).