From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vihas Makwana <makvihas@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv
Date: Mon, 11 Apr 2022 11:06:23 +0300 [thread overview]
Message-ID: <20220411080623.GB12805@kadam> (raw)
In-Reply-To: <CAH1kMwTPkPV=gLg38m=yq=n1U2Mqa4+1XNtB_5Kc2y7O0mpMpQ@mail.gmail.com>
On Sun, Apr 10, 2022 at 11:08:02PM +0530, Vihas Makwana wrote:
> > On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> > > Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> > > be moved to _rtw_free_cmd_priv.
> >
> > If you are going to drop wrappers, my preference would be
> > to drop the underscore prefixed ones.
> >
> Yes, that was my initial thought too. But there are already some init
> and free functions in the module with underscores prefixed.
> So I didn't do it that way. Maybe the developers kept it that way for
> some reason.
Yeah, no. There is no reason. Get rid of the underscores.
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-11 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 16:31 [PATCH 0/6] drop some unnecessary wrappers Vihas Makwana
2022-04-10 16:31 ` [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv Vihas Makwana
2022-04-10 17:07 ` Joe Perches
2022-04-10 17:38 ` Vihas Makwana
2022-04-11 8:06 ` Dan Carpenter [this message]
2022-04-10 16:31 ` [PATCH 2/6] staging: r8188eu: drop unnecessary wrapper rtw_init_cmd_priv Vihas Makwana
2022-04-10 16:31 ` [PATCH 3/6] staging: r8188eu: drop unnecessary wrapper rtw_init_evt_priv Vihas Makwana
2022-04-10 16:31 ` [PATCH 4/6] staging: r8188eu: drop unnecessary wrapper rtw_dequeue_cmd Vihas Makwana
2022-04-10 16:31 ` [PATCH 5/6] staging: r8188eu: drop unnecessary wrapper rtw_init_mlme_priv Vihas Makwana
2022-04-10 16:31 ` [PATCH 6/6] staging: r8188eu: drop unnecessary wrapper rtw_free_mlme_priv Vihas Makwana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411080623.GB12805@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox