public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Jaehee Park <jhpark1013@gmail.com>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stefano Brivio <sbrivio@redhat.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev,
	Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif
Date: Tue, 12 Apr 2022 00:18:13 -0400	[thread overview]
Message-ID: <20220412041813.GA2860081@jaehee-ThinkPad-X1-Extreme> (raw)
In-Reply-To: <2419031.jE0xQCEvom@pc-42>

On Sat, Apr 09, 2022 at 04:07:12PM +0200, Jérôme Pouiller wrote:
> On Friday 8 April 2022 07:44:24 CEST Stefano Brivio wrote:
> > On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> > > >
> > > > [...]
> > > >
> > > > @@ -61,7 +63,6 @@ struct wfx_dev {
> > > >
> > > >  struct wfx_vif {
> > > >     struct wfx_dev             *wdev;
> > > > -   struct ieee80211_vif       *vif;
> > >
> > > You need to test this on real hardware.  For an outreachy-first-task,
> > > this is not a good one at all.
> > 
> > We discussed about this on the outreachy list, and I suggested, as
> > Jaehee also mentioned, that maybe somebody (Jérôme?) with the hardware
> > could give it a try.
> >
> > It looks a bit difficult but it also looks almost correctly done now. :)
> 
> Absolutely.
> 
> I will test it once the various comments will be fixed.
> 
> 
> -- 
> Jérôme Pouiller
> 
>
I just wanted to update and let you know that I mailed a new patch v3 just now.
Thanks!

  reply	other threads:[~2022-04-12  4:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  3:23 [PATCH v2] staging: wfx: use container_of() to get vif Jaehee Park
2022-04-08  4:45 ` Greg Kroah-Hartman
2022-04-08  5:44   ` Stefano Brivio
2022-04-09 14:07     ` Jérôme Pouiller
2022-04-12  4:18       ` Jaehee Park [this message]
2022-04-08  5:43 ` Stefano Brivio
2022-04-08 22:07   ` Jaehee Park
2022-04-08  6:19 ` Dan Carpenter
2022-04-12  3:57   ` Jaehee Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412041813.GA2860081@jaehee-ThinkPad-X1-Extreme \
    --to=jhpark1013@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jerome.pouiller@silabs.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox