public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Aliya Rahmani <aliyarahmani786@gmail.com>
To: forest@alittletooquiet.net
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev,
	Aliya Rahmani <aliyarahmani786@gmail.com>
Subject: [PATCH v4] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('
Date: Fri, 15 Apr 2022 10:49:01 +0530	[thread overview]
Message-ID: <20220415051900.5801-1-aliyarahmani786@gmail.com> (raw)

Code style warnings reported by checkpatch.
Improve the layout of a function header:
*Put the first parameter immediately after the '(' and align the other
parameters underneath it.

Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
---
v1->v2 changes: Put static and void on a single line.

v2->v3->v4 changes: Rework commit description.

---
 drivers/staging/vt6655/rxtx.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 53506e242a96..01dc83b2f4bc 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -567,19 +567,16 @@ s_uFillDataHead(
 	return buf->duration;
 }
 
-static
-void
-s_vFillRTSHead(
-	struct vnt_private *pDevice,
-	unsigned char byPktType,
-	void *pvRTS,
-	unsigned int cbFrameLength,
-	bool bNeedAck,
-	bool bDisCRC,
-	struct ieee80211_hdr *hdr,
-	unsigned short wCurrentRate,
-	unsigned char byFBOption
-)
+static void
+s_vFillRTSHead(struct vnt_private *pDevice,
+		unsigned char byPktType,
+		void *pvRTS,
+		unsigned int cbFrameLength,
+		bool bNeedAck,
+		bool bDisCRC,
+		struct ieee80211_hdr *hdr,
+		unsigned short wCurrentRate,
+		unsigned char byFBOption)
 {
 	unsigned int uRTSFrameLen = 20;
 
-- 
2.25.1


             reply	other threads:[~2022-04-15  5:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  5:19 Aliya Rahmani [this message]
2022-04-15  5:44 ` [PATCH v4] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '(' Fabio M. De Francesco
2022-04-15  9:08   ` Julia Lawall
2022-04-15 11:31 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220415051900.5801-1-aliyarahmani786@gmail.com \
    --to=aliyarahmani786@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox