From: Jaehee Park <jhpark1013@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev,
Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments
Date: Sun, 17 Apr 2022 16:49:49 -0400 [thread overview]
Message-ID: <20220417204949.GA238538@jaehee-ThinkPad-X1-Extreme> (raw)
In-Reply-To: <6925e230-b816-ea9a-067f-60cefecd8af7@gmail.com>
On Sun, Apr 17, 2022 at 11:23:03PM +0300, Pavel Skripkin wrote:
> Hi Jaehee,
>
> On 4/15/22 05:48, Jaehee Park wrote:
> > Author comments "Added by Albert" and "Added by Annie" are sprinkled
> > through the file. These comments are not useful and can be removed.
> >
> > Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
>
> I don't remember giving that tag, but now I am OK with it, since patch looks
> good
>
> Please, don't put random Reviewed-by tags in your commit message, since it's
> not how Reviewed-by tags work
Got it. Thanks
>
> > Suggested-by: Alison Schofield <alison.schofield@intel.com>
> > Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
>
>
>
>
> With regards,
> Pavel Skripkin
next prev parent reply other threads:[~2022-04-17 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:48 [PATCH v2 0/6] staging: r8188eu: fix warnings reported by checkpatch Jaehee Park
2022-04-15 2:48 ` [PATCH v2 1/6] staging: r8188eu: remove unused member free_bss_buf Jaehee Park
2022-04-15 4:29 ` Fabio M. De Francesco
2022-04-17 20:14 ` Jaehee Park
2022-04-17 20:16 ` Pavel Skripkin
2022-04-17 20:42 ` Jaehee Park
2022-04-17 21:13 ` Fabio M. De Francesco
2022-04-17 22:01 ` Fabio M. De Francesco
2022-04-18 4:49 ` Jaehee Park
2022-04-15 2:48 ` [PATCH v2 2/6] staging: r8188eu: remove spaces before tabs Jaehee Park
2022-04-15 2:48 ` [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments Jaehee Park
2022-04-17 20:23 ` Pavel Skripkin
2022-04-17 20:49 ` Jaehee Park [this message]
2022-04-15 2:48 ` [PATCH v2 4/6] staging: r8188eu: place constants on the right side of tests Jaehee Park
2022-04-15 4:57 ` Fabio M. De Francesco
2022-04-15 2:48 ` [PATCH v2 5/6] staging: r8188eu: replace spaces with tabs Jaehee Park
2022-04-15 2:48 ` [PATCH v2 6/6] staging: r8188eu: correct typo in comments Jaehee Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220417204949.GA238538@jaehee-ThinkPad-X1-Extreme \
--to=jhpark1013@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alison.schofield@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox