From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: r8188eu: use ARRAY_SIZE for mlme_sta_tbl
Date: Fri, 22 Apr 2022 13:08:01 +0300 [thread overview]
Message-ID: <20220422100800.GG2462@kadam> (raw)
In-Reply-To: <20220417102221.466524-7-martin@kaiser.cx>
On Sun, Apr 17, 2022 at 12:22:21PM +0200, Martin Kaiser wrote:
> Use ARRAY_SIZE instead of hard-coding the number of entries in the
> mlme_sta_tbl array.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index abb910f33c1c..973adebdd69c 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -404,7 +404,7 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
> return;
>
> index = (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4;
> - if (index > 13)
> + if (index > ARRAY_SIZE(mlme_sta_tbl))
^
This is an off by one. Should be >=. The auto builders would have
caught this eventually.
> return;
> fct = mlme_sta_tbl[index];
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-22 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 10:22 [PATCH 0/6] staging: r8188eu: clean up mgt_dispatcher Martin Kaiser
2022-04-17 10:22 ` [PATCH 1/6] staging: r8188eu: check receiver address only once Martin Kaiser
2022-04-17 10:22 ` [PATCH 2/6] staging: r8188eu: replace the GetFrameSubType call Martin Kaiser
2022-04-17 10:22 ` [PATCH 3/6] staging: r8188eu: the frame type is shifted out Martin Kaiser
2022-04-17 10:22 ` [PATCH 4/6] staging: r8188eu: replace mlme_handler with function pointer Martin Kaiser
2022-04-17 10:22 ` [PATCH 5/6] staging: r8188eu: don't call empty DoReserved function Martin Kaiser
2022-04-17 10:22 ` [PATCH 6/6] staging: r8188eu: use ARRAY_SIZE for mlme_sta_tbl Martin Kaiser
2022-04-22 10:08 ` Dan Carpenter [this message]
2022-04-22 10:20 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422100800.GG2462@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox