From: Dan Carpenter <dan.carpenter@oracle.com>
To: Uri Arev <me@wantyapps.xyz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: fix indentation according to checkpatch.pl
Date: Wed, 18 May 2022 08:40:03 +0300 [thread overview]
Message-ID: <20220518054003.GQ4009@kadam> (raw)
In-Reply-To: <20220517222710.678033-1-me@wantyapps.xyz>
On Wed, May 18, 2022 at 01:27:09AM +0300, Uri Arev wrote:
> (My first patch!)
>
Don't put this kind of stuff into the permanent git log. :P
> scripts/checkpatch.pl warned about an indentation problem in
> the axis-fifo.c file.
>
> Checkpatch warning:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Uri Arev <me@wantyapps.xyz>
> ---
^^^
If you're sending a v2 patch then put a note here under the --- cut
off to say what changed since the previous version:
---
v2: something something blah blah blah
> drivers/staging/axis-fifo/axis-fifo.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index dfd2b357f484..51ce48e68e27 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -383,10 +383,10 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - (read_timeout >= 0) ?
> - msecs_to_jiffies(read_timeout) :
> - MAX_SCHEDULE_TIMEOUT);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + (read_timeout >= 0) ?
> + msecs_to_jiffies(read_timeout) :
> + MAX_SCHEDULE_TIMEOUT);
This is too far to the right now. It was basically fine to start with.
Just ignore checkpatch this time.
regards,
dan carpenter
prev parent reply other threads:[~2022-05-18 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 22:27 [PATCH v2] staging: axis-fifo: fix indentation according to checkpatch.pl Uri Arev
2022-05-18 5:40 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518054003.GQ4009@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@wantyapps.xyz \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox