Re: [PATCH] staging: qlge: qlge_main.c: convert do-while loops to for loops

Dan Carpenter
2022-06-09T15:27:25Z

On Thu, Jun 09, 2022 at 11:15:51AM -0400, Srivathsan Sivakumar wrote:
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 8c35d4c4b851..308e8b621185 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3006,13 +3006,13 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> cqicb->flags |= FLAGS_LL; /* Load lbq values */
> tmp = (u64)rx_ring->lbq.base_dma;
> base_indirect_ptr = rx_ring->lbq.base_indirect;
> - page_entries = 0;
> - do {
> - *base_indirect_ptr = cpu_to_le64(tmp);
> - tmp += DB_PAGE_SIZE;
> - base_indirect_ptr++;
> - page_entries++;
> - } while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN));
> +
> + for (page_entries = 0; page_entries <
> + MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) {
> + *base_indirect_ptr = cpu_to_le64(tmp);
> + tmp += DB_PAGE_SIZE;
> + base_indirect_ptr++;
> + }

It's better than the original, but wouldn't it be better yet to write
something like this (untested):

for (i = 0; i < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); i++)
base_indirect_ptr[i] = cpu_to_le64(tmp + (i * DB_PAGE_SIZE));

Same with the other as well, obviously.

regards,
dan carpenter