* [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function
@ 2022-06-23 2:24 Chang Yu
2022-06-23 4:21 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Chang Yu @ 2022-06-23 2:24 UTC (permalink / raw)
To: Larry.Finger; +Cc: linux-staging, linux-kernel, Chang Yu
Make rtw_signal_stat_timer_hdl a static function instead of a global
function.
Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---
drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index cc91638a085d..599d3e55be76 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
};
-void rtw_signal_stat_timer_hdl(struct timer_list *t);
+static void rtw_signal_stat_timer_hdl(struct timer_list *t);
void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
{
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function
2022-06-23 2:24 [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function Chang Yu
@ 2022-06-23 4:21 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2022-06-23 4:21 UTC (permalink / raw)
To: Chang Yu, Larry.Finger; +Cc: linux-staging, linux-kernel
On 6/23/22 04:24, Chang Yu wrote:
> Make rtw_signal_stat_timer_hdl a static function instead of a global
> function.
>
> Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index cc91638a085d..599d3e55be76 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
> 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> };
>
> -void rtw_signal_stat_timer_hdl(struct timer_list *t);
> +static void rtw_signal_stat_timer_hdl(struct timer_list *t);
>
> void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
> {
Hi,
thanks for your patch. I think you need the "static" for the declaration
and the definition of the function. So it is missing in line 1789.
Thanks for your support.
Bye Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-23 4:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 2:24 [PATCH] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function Chang Yu
2022-06-23 4:21 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox