From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228A01C39 for ; Sun, 10 Jul 2022 20:55:14 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id bf13so3161076pgb.11 for ; Sun, 10 Jul 2022 13:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qQKjxcYz1SGrja/RVWPyvjQAdujAs0bm/5MR0Zd7Fbs=; b=J3T5xnG1aPiHUNRQPunaMCimNV7xGov7UtdtYdHjaMGT6u0XnG5UsGmHJSLPOKXzn8 J7nMnII2QM10Qhl5LHKZJKUrrFFZK4V0wwUc4w3aXHt+cQcj2s55m7Kn40IYEDhUKqTb dSwMuwcjOEXlC4wNQ6+ODl8OgELw4mXnHHj1wrfu3Cfkdx1bgCseS64zjhFdMSRmY2pj HcUrWodW2cY1xOKmN5ahKPKXtkrgZWsvc99irE6xip8ou5SnXmApnqWIrCuz1kxFuz8z 6Tm/J379p46vZwowXNbim6uD1hNpMSsNLsN7wmMbaLFyFoDLuNy5VPyF7wV8UcIBZk+b Gx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qQKjxcYz1SGrja/RVWPyvjQAdujAs0bm/5MR0Zd7Fbs=; b=vAmKwc6HCzA1LRbuUPqbxxImyIJmA3aj0+gX+v++4Z0BjLYpZaBP16bGrIj+z3fqhZ DcryKNAqIXwC0oo9l3h7rFUVgQxBKBwpIG3mK8UFo2Sa7rRpXR54ZpPMvDjNzfugv1cS w3nIhLBCjn2SK1gb5579xKNUiMEI2cqZiClnS+wWdtNA+3II+/NFdaYDIVMIWnfV0N1x qKFfiQJVgUCz3LvEdM6UIofvH30IJs+ucFXTaWFSP3k0xLkio6FqlyBpnWaHrW0xCA/A 3qWTlmUzDRYodkknpl8FqO5183RMDKGoW4wY69f8qcJQTCtwLNlVk/rjGOJZ5OkozNRf o8wg== X-Gm-Message-State: AJIora/k21Kzwxs+4UsU1BXreEA7sNUXWHnl0pGb6iFd1T6WPP+HUawF RYFr9SQAbdn7gt0PWQZhRhk= X-Google-Smtp-Source: AGRyM1v/0pHHJkcEvPg32H/Zrta20c9KMIwYkT2EJglL1F4N05DErX0mIwaKlQWfsGCUQACIrQO7Dw== X-Received: by 2002:a63:69ca:0:b0:411:994d:1e29 with SMTP id e193-20020a6369ca000000b00411994d1e29mr13517561pgc.118.1657486513481; Sun, 10 Jul 2022 13:55:13 -0700 (PDT) Received: from cloud-MacBookPro ([2601:646:8201:c2e0:4045:a2e:ac7a:d1f4]) by smtp.gmail.com with ESMTPSA id js1-20020a17090b148100b001ef7e5f2a82sm3235158pjb.25.2022.07.10.13.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 13:55:13 -0700 (PDT) Date: Sun, 10 Jul 2022 13:55:12 -0700 From: binyi To: Joe Perches Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: qlge: Fix indentation issue under long for loop Message-ID: <20220710205512.GA1883@cloud-MacBookPro> References: <20220710083657.GA3311@cloud-MacBookPro> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Jul 10, 2022 at 08:28:57AM -0700, Joe Perches wrote: > On Sun, 2022-07-10 at 01:36 -0700, Binyi Han wrote: > > Fix indentation issue to adhere to Linux kernel coding style, > > Issue found by checkpatch. And change the long for loop into 3 lines. > > > > Signed-off-by: Binyi Han > > --- > > v2: > > - Change the long for loop into 3 lines. > > > > drivers/staging/qlge/qlge_main.c | 18 ++++++++++-------- > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > > index 1a378330d775..6e771d0e412b 100644 > > --- a/drivers/staging/qlge/qlge_main.c > > +++ b/drivers/staging/qlge/qlge_main.c > > @@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring > > tmp = (u64)rx_ring->lbq.base_dma; > > base_indirect_ptr = rx_ring->lbq.base_indirect; > > > > - for (page_entries = 0; page_entries < > > - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) > > - base_indirect_ptr[page_entries] = > > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > + for (page_entries = 0; > > + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); > > + page_entries++) > > + base_indirect_ptr[page_entries] = > > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > Better to align page_entries to the open parenthesis. > > And another optimization would be to simply add DB_PAGE_SIZE to tmp > in the loop and avoid the multiply. > > for (page_entries = 0; > page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); > page_entries++) { > base_indirect_ptr[page_entries] = cpu_to_le64(tmp); > tmp += DB_PAGE_SIZE; > } > > > @@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring > > tmp = (u64)rx_ring->sbq.base_dma; > > base_indirect_ptr = rx_ring->sbq.base_indirect; > > > > - for (page_entries = 0; page_entries < > > - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) > > - base_indirect_ptr[page_entries] = > > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > + for (page_entries = 0; > > + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); > > + page_entries++) > > + base_indirect_ptr[page_entries] = > > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); > > here too > Ah I see, that makes sense. Thanks for reviewing!