From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C2D010FA for ; Tue, 19 Jul 2022 05:51:57 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id j1-20020a17090aeb0100b001ef777a7befso888629pjz.0 for ; Mon, 18 Jul 2022 22:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UGreb3otYXicSc9AyATwfdoBfIrCHzGc1xh2ozqtBEs=; b=OYOtd68a+OLe314P9GifUJZ4m5i3HRORK2DfvIerbUosILabyXspkzeS5vIBIQ/jrS oc+68fW3haoF+noCVEKxfrQah/IRqa25Db3KLUH/emzoGOXrD0QeqQIfxECtcGeLdmZy rRUHe8JfuFS6HO3DzmsbPX0wme1xbPcSqO31gbBoanjWiOAp0YNcCgO9wuL2rk37hY6z 0QmsZy6GRnkyOXNVfFNwGsf+fnqmwt7N/iwEXOPDt94a7QTd3C9uWlFTCDtZLAiSy7SW pRP5qX1sDDYxNb687kR0UccQEfflolGuhkAfr12k441kpCaS1umwfOUk9zBrHn9CR9TA KASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UGreb3otYXicSc9AyATwfdoBfIrCHzGc1xh2ozqtBEs=; b=sZHli0p4aRhPkDA3gKaP/ANJc9CJ8e1jPObWmy0jczzHoMQpRaKHVd3IAV8K1r8c1u /sZqKDClcjoVQaI0hWYd9Fg6zAA/NGjcL3DmrEXY+XkECkdVgxuZOw6SM0v8//B95Ekc /SsRtMixBOd46tuJlfd1xk0Co8LNxmva5H4N82Gr7SpDe0+nzX4YJ2H7VOXffH30Bdtj O6W345PD4sg/6C9/V03QpPyyIQGw6j7nlYgHCzwwfOoJZ1AQPTUlaxbrMoFgyxItY9Nk hbLEFzbKXoDnm23KFBanbKJKvSa39x229swu2zTBW1URh/M2XouruwByd42tQmEVKp+5 RWEw== X-Gm-Message-State: AJIora/gGIifojN+iSMZAc26MhUkeggbBnH6K5rY7xswXK2PM5DWwdYP PZHPJsW3QnquO52nmgW2OZw= X-Google-Smtp-Source: AGRyM1sX9nh7byGS6CEA4k7+qgl41c1iGJZdTnsJrRtnXvbhEqxKSuT1A3hHcenz54XRD4jULoHh1w== X-Received: by 2002:a17:90a:bc8c:b0:1ef:91ca:1c24 with SMTP id x12-20020a17090abc8c00b001ef91ca1c24mr42539239pjr.81.1658209916771; Mon, 18 Jul 2022 22:51:56 -0700 (PDT) Received: from tong-desktop.local ([2600:1700:3ec7:421f:33db:e37c:7ee3:662b]) by smtp.googlemail.com with ESMTPSA id a16-20020a170902ecd000b0016c20d40ee7sm10709338plh.174.2022.07.18.22.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 22:51:56 -0700 (PDT) From: Tong Zhang To: Greg Kroah-Hartman , Tong Zhang , Jakub Kicinski , Colin Ian King , Saurav Girepunje , Nathan Chancellor , Johan Hovold , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: dan.carpenter@oracle.com, Zheyu Ma Subject: [PATCH v2 0/3] staging: rtl8192u: fix rmmod warn when wlan0 is renamed Date: Mon, 18 Jul 2022 22:50:35 -0700 Message-Id: <20220719055047.322355-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220718120149.GD2338@kadam> References: <20220718120149.GD2338@kadam> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are 4 debug files created under /proc/net/[Devname]. Devname could be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002. This will cause problem during debug file teardown since it uses netdev->name which is no longer wlan0. To solve this problem, add a notifier to handle device renaming. Also, due to this is purely for debuging as files are created read only, move this to debugfs like other NIC drivers do instead of using procfs. Reported-by: Zheyu Ma Tested-by: Zheyu Ma Signed-off-by: Tong Zhang v2: break down patch and fix pointer check Tong Zhang (3): staging: rtl8192u: move debug stuff to its own file staging: rtl8192u: move debug files to debugfs staging: rtl8192u: fix rmmod warn when wlan0 is renamed drivers/staging/rtl8192u/Makefile | 1 + drivers/staging/rtl8192u/r8192U.h | 6 + drivers/staging/rtl8192u/r8192U_core.c | 223 ++++------------------ drivers/staging/rtl8192u/r8192U_debugfs.c | 188 ++++++++++++++++++ 4 files changed, 235 insertions(+), 183 deletions(-) create mode 100644 drivers/staging/rtl8192u/r8192U_debugfs.c -- 2.25.1