From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7EE6AD4 for ; Fri, 22 Jul 2022 19:25:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71F02C341C6; Fri, 22 Jul 2022 19:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658517918; bh=xuKtXsTHkn0pTkQYNaGYt7up+YxyXAU6zKa8/F8cb4Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GvVYEz0XVqnnIsn/hR7I+ZMQYYiGNijjl3vDCaO3PrCyIBGadxMl1Lym1d6CZOFYU jXG3IRvDRcyb1jtrPEFjCf5zUoP1AwSdyVmbGXq0yYYGtEsJeJ3rzXHkEP8zMWsLWA 2jdQlEMa0uoblsJ9U3ojOVp/Q5wQ1QnLymTnQ9q4hNURDXqCiHF8801S03fKjNh1B2 AKez12l/WgOBFyzQOwiVFeBJdQIetKO91HmKRJfq+M0B+CyPrynklOF+JT31gyUwAq I+RPJ0zEhdSeLfy2qcnFOTDAsg+t2kpfsh90wjFjfxtUAoSCOATz+l7efrG+mFtcU4 duPVtPhCFkcog== Date: Fri, 22 Jul 2022 21:25:12 +0200 From: Mauro Carvalho Chehab To: Philipp Hortmann Cc: Abhijeet Srivastava , Corentin Labbe , Greg Kroah-Hartman , mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: media: zoran: Deleted dead code Message-ID: <20220722212512.265cc13d@coco.lan> In-Reply-To: <614ce7e3-ff4e-5d76-e940-2aa222535743@gmail.com> References: <20220722182622.23719-1-abhijeet.srivastava2308@gmail.com> <614ce7e3-ff4e-5d76-e940-2aa222535743@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Fri, 22 Jul 2022 20:52:29 +0200 Philipp Hortmann escreveu: > On 7/22/22 20:26, Abhijeet Srivastava wrote: > > Deleted part of code in block comment > > > > Signed-off-by: Abhijeet Srivastava > > --- > > drivers/staging/media/zoran/zoran_driver.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c > > index b408c1d4e0a7..836edf623571 100644 > > --- a/drivers/staging/media/zoran/zoran_driver.c > > +++ b/drivers/staging/media/zoran/zoran_driver.c > > @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = { > > .vidioc_enum_input = zoran_enum_input, > > .vidioc_g_input = zoran_g_input, > > .vidioc_s_input = zoran_s_input, > > - > > -/* .vidioc_enum_output = zoran_enum_output, > > - * .vidioc_g_output = zoran_g_output, > > - * .vidioc_s_output = zoran_s_output, > > - */ > > .vidioc_g_std = zoran_g_std, > > .vidioc_s_std = zoran_s_std, > > .vidioc_create_bufs = vb2_ioctl_create_bufs, > > @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = { > > .vidioc_streamon = vb2_ioctl_streamon, > > .vidioc_streamoff = vb2_ioctl_streamoff, > > .vidioc_enum_fmt_vid_cap = zoran_enum_fmt_vid_cap, > > -/* .vidioc_enum_fmt_vid_out = zoran_enum_fmt_vid_out,*/ > > .vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap, > > -/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/ > > .vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap, > > -/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/ > > .vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap, > > -/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/ > > .vidioc_subscribe_event = v4l2_ctrl_subscribe_event, > > .vidioc_unsubscribe_event = v4l2_event_unsubscribe, > > }; > > Why does the subject line start with "media:" The subsystem is > "staging:" so the subject should start with "staging: media: ..." > > I have no clue if this is accepted. The subsystem is media. The drivers for both drivers/media and drivers/staging/media have the same maintainers. The "staging" is just a place where we place stuff that are either not ready for upstream or are under deprecation. So, we expect that all subjects start with media:. I prefer if they don't have "staging" at the subject, as makes the driver logs more coherent when they're moved in/out staging dir. Regards, Mauro