From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Phillip Potter <phil@philpotter.co.uk>,
gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
paskripkin@gmail.com, martin@kaiser.cx, straube.linux@gmail.com,
fmdefrancesco@gmail.com, abdun.nihaal@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics
Date: Mon, 1 Aug 2022 12:17:36 +0300 [thread overview]
Message-ID: <20220801091735.GB3460@kadam> (raw)
In-Reply-To: <f93d3ea32ac04a5edd8159abcb0504f71fe7aee4.camel@perches.com>
On Sun, Jul 31, 2022 at 10:12:56AM -0700, Joe Perches wrote:
> > I'm happy of course to rewrite this to address any concerns, but
> > I was hoping I could clarify what you've said though? Apologies if I've
> > missed it, but how is this function now returning 1 on success? It sets
> > ret to 0 (success) at the start and then sets it to one of two negative
> > error codes depending on what happens. Am I missing something here?
> > (Perfectly possible that I am).
> >
> > In terms of do nothing gotos, do you mean gotos that just set an error
> > code then jump to the end? If you'd prefer, as the function just returns
> > right after the exit label, I can just return the codes directly and have
> > a 'return 0;' like you say above?
> >
> > Thanks as always for your insight.
>
> Yes, you've got it right.
>
> I think Dan is suggesting something like the below, but
> not necessarily in a single patch:
I always like your style, Joe.
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-01 9:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 23:11 [PATCH 0/2] staging: r8188eu: more error code cleanups Phillip Potter
2022-07-28 23:11 ` [PATCH 1/2] staging: r8188eu: remove initializer from ret in rtw_pwr_wakeup Phillip Potter
2022-07-28 23:11 ` [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics Phillip Potter
2022-07-29 6:48 ` Dan Carpenter
2022-07-30 18:36 ` Phillip Potter
2022-07-31 17:12 ` Joe Perches
2022-08-01 9:17 ` Dan Carpenter [this message]
2022-08-02 23:26 ` Phillip Potter
2022-08-01 7:00 ` Dan Carpenter
2022-08-02 20:10 ` Pavel Skripkin
2022-08-02 22:15 ` Phillip Potter
2022-07-29 6:09 ` [PATCH 0/2] staging: r8188eu: more error code cleanups Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801091735.GB3460@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abdun.nihaal@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox