From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF0F523C8 for ; Thu, 18 Aug 2022 06:44:38 +0000 (UTC) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5884D3F0EB for ; Thu, 18 Aug 2022 06:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1660805075; bh=DlhFnIdUMBOYUKK8lBE6v5auDBKzAT3PWLok7Bl69AQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uG3DQZHoedbQQZf+hoDyE2hDkQYNAP17EpN7e+wTeappdjx96S+9DJgGloJKFFBvG l4dS3uNoPXe6XXc2DjlUslSl0k+Gc6SJIAWjmF8DlF4Co7UMrCyCQJ+jzqhDPv0ju1 bePd9INPcLoc2/b2e5vjzKfsiTHtKoPbMklRzy/0bGl9S3Cm+1E0TKhBNi2mayMMob mUfa08QD3Ml9uuGX7CewD55AO3RMFO4uLB5M4NN/MTCusUXP/m/iSmCToom2iLNcSe Yh7I23KTSViOxG8JPGigbPuftlUfRLRdjdd9MWKlYdU3gMVnwFVnphwckRJ1RR0WkW pYT8Ferz6kj6Q== Received: by mail-ed1-f70.google.com with SMTP id o2-20020a056402438200b0043d552deb2aso400686edc.0 for ; Wed, 17 Aug 2022 23:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:organization:references:in-reply-to:message-id:subject :cc:to:from:date:x-gm-message-state:from:to:cc; bh=DlhFnIdUMBOYUKK8lBE6v5auDBKzAT3PWLok7Bl69AQ=; b=T9mOHUVJAFVKwnum47M5v5DOeFgeHIjmkCJXuteHvjWCIshfJ44V+TCMUekkNXVWOT 8JrnfTHcMKd4rmY6v9M6XDJWWWXtxCkHP52T1SlCXg4wqhlgLhhIrQ5j2hI0AxPsTDLV i1MiYAwi0pg3porZT6rjRBd8R1zL5lgOEFnjz3OOGmnnXeYZ2FlLYfjFCuQkyRucKiyR cqFSMwmmQIIhgK44N2qvU7zOuQfIX01E2v0MP6wn1DNePertQZuopzO5UG1FNVDQaPLE 92lQkbK+W9zfn04w0iW/qLhlB3X2hgHbf3CuDheXoVHOof61Q8CZi6eb5qscL39U9Kj8 5Chw== X-Gm-Message-State: ACgBeo1YqPCf1HQ0iZy9lcp+ZjFbKSr7GwbodGCpYZxsHfwyI693uDEh 0ujGaxUDz5e7cC4QlZAH19WrYrfJ0F8skBhtPNYSky5RyNtFpeCIemuM2sqY9d59wgHNc+5t8xp auzsImF0cSa1bqPY06e6BWRBH2ZsPnUYRtvOaErSvwWs= X-Received: by 2002:aa7:d508:0:b0:445:dd73:4f6f with SMTP id y8-20020aa7d508000000b00445dd734f6fmr1100782edq.231.1660805075103; Wed, 17 Aug 2022 23:44:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR6ZAU7Kf5zJnIs7zdYVrqU4dSuauM0GuoeE5k0wyJ9b5fwFVy3N4F7Qic0fUtdAg9Mt31Q0pA== X-Received: by 2002:aa7:d508:0:b0:445:dd73:4f6f with SMTP id y8-20020aa7d508000000b00445dd734f6fmr1100767edq.231.1660805074928; Wed, 17 Aug 2022 23:44:34 -0700 (PDT) Received: from smeagol ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id 2-20020a170906300200b00721d8e5bf0bsm399793ejz.6.2022.08.17.23.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 23:44:33 -0700 (PDT) Date: Thu, 18 Aug 2022 08:44:30 +0200 From: Juerg Haefliger To: Neil Armstrong Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro Message-ID: <20220818084430.0ca10b30@smeagol> In-Reply-To: <04115bee-5ddb-701f-ad18-d2c846155816@baylibre.com> References: <20220817140539.150013-1-juerg.haefliger@canonical.com> <04115bee-5ddb-701f-ad18-d2c846155816@baylibre.com> Organization: Canonical Ltd X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/NRjcrFgnzwojt7mVFj1UxFl"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Sig_/NRjcrFgnzwojt7mVFj1UxFl Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 17 Aug 2022 18:08:19 +0200 Neil Armstrong wrote: > On 17/08/2022 16:05, Juerg Haefliger wrote: > > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to > > provide that information via modinfo. > >=20 > > Signed-off-by: Juerg Haefliger > > --- > > .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > >=20 > > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers= /staging/media/meson/vdec/vdec_platform.c > > index 88c9d72e1c83..c7750d4be848 100644 > > --- a/drivers/staging/media/meson/vdec/vdec_platform.c > > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c > > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 =3D { > > .num_formats =3D ARRAY_SIZE(vdec_formats_sm1), > > .revision =3D VDEC_REVISION_SM1, > > }; > > + > > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); =20 >=20 > Duplicate Oh this is embarrassing :-( > > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); =20 >=20 > DDDDDDDuplicate >=20 > > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); =20 >=20 > Duplicate >=20 > > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin"); =20 >=20 > With the duplicate entries removed, please add my: > Reviewed-by: Neil Armstrong Will do. Thanks for the review. ...Juerg --Sig_/NRjcrFgnzwojt7mVFj1UxFl Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAmL9388ACgkQD9OLCQum QrdG7Q/9FwPE/3/kGYBq248tkz8znw0beqrk7fc04SQdThTNb+Nm8x+4ozI/vs7r ybj+Pysjebw37NTrhjZCXGisHt02zs9D0yZmN2bkoHOvP/2ADhrlfI2x6Bmb7VZo Tmd1EXUHSBI9mJEA3Po0grFqq/I4Pz9ntVHMKrxUdCd/0iEKHHnSb8l4Zo6upq1s cBYpAvHi393MGpgI91gqHv3QowE/IpNFLhxt3/hgFUxi8BiUsOJBetO7c+kBIBHi YqqUvTd4seKYzctWYGdbB94EW15mMALypsQMsR28UKwCcd1aC0dmV4r/o99sCajP Xxyb0Ud9t/j6wXdR1hnU//bkOvOtOjDEgRKHVunfKALOFq8XleCW+2ZSEQGWqZXG kDJeLs6RyKBZPWWn/IvY9tmVv79iPcODEYXSdW7BKzj9p5Syqaf+3cAB/Td4wlNV O+/NFPbS4FrsMV3r+0OgR9+N9IfyFUutlZosW56uzHKbaq2pOvcLUBLdYY73jsn2 r8M+chwvKhdL2fG4nZR/a18/Vot5c3CaUQ0arMLEZBxzI4joAHYcgzId0ICztk75 zmZB+rrpvOsUgseQhcQV5xcJ5zmS2sV/EAfWROXnl1OWU1tW3OXAcn8gOgz4KBsY v5WXJcCjdolJhr/7p67181WQavdvxW/4B8lOq1xFp3l+FKHbnU4= =3reT -----END PGP SIGNATURE----- --Sig_/NRjcrFgnzwojt7mVFj1UxFl--