From: Dan Carpenter <dan.carpenter@oracle.com>
To: GUO Zihua <guozihua@huawei.com>
Cc: linux-staging@lists.linux.dev, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, paskripkin@gmail.com
Subject: Re: [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit
Date: Fri, 2 Sep 2022 12:10:40 +0300 [thread overview]
Message-ID: <20220902091040.GO2071@kadam> (raw)
In-Reply-To: <20220902081653.60682-1-guozihua@huawei.com>
This is not a RESEND. A RESEND means your patch was perfect and the
problem was on our end. Of course, we're also human so sometimes we
make mistakes but a RESEND requires an investigation why we are
ignoring *perfect* patches.
This is a V2 patch. Here is my blog entry on how to send a v2 patch:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
You need to send a v3 patch now.
On Fri, Sep 02, 2022 at 04:16:53PM +0800, GUO Zihua wrote:
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this might get
> cought out by CFI and cause a panic.
>
> Use enums from netdev_tx_t as return value instead, then change return
> type to netdev_tx_t.
What CFI is C-something Fault Injection? How does this cause a panic?
Do you have a stack trace? This commit message is not clear at all.
regards,
dan carpenter
prev parent reply other threads:[~2022-09-02 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 8:16 [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit GUO Zihua
2022-09-02 8:25 ` Greg KH
2022-09-05 1:23 ` Guozihua (Scott)
2022-09-05 5:16 ` Greg KH
2022-09-05 13:08 ` Guozihua (Scott)
2022-09-02 9:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902091040.GO2071@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=guozihua@huawei.com \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox