From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 3/6] staging: r8188eu: remove unnecessary initialization
Date: Sun, 11 Sep 2022 18:19:46 +0200 [thread overview]
Message-ID: <20220911161949.11293-4-straube.linux@gmail.com> (raw)
In-Reply-To: <20220911161949.11293-1-straube.linux@gmail.com>
The variable 'retsig' in odm_signal_scale_mapping() is set in the
function before it returns, so it is not needed to initialize it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c
index 5fd53c60f762..a557c5d1542e 100644
--- a/drivers/staging/r8188eu/hal/odm_HWConfig.c
+++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c
@@ -15,7 +15,7 @@ static u8 odm_QueryRxPwrPercentage(s8 AntPower)
static s32 odm_signal_scale_mapping(struct odm_dm_struct *dm_odm, s32 currsig)
{
- s32 retsig = 0;
+ s32 retsig;
if (currsig >= 51 && currsig <= 100)
retsig = 100;
--
2.37.3
next prev parent reply other threads:[~2022-09-11 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 16:19 [PATCH 0/6] staging: r8188eu: some coding style cleanups Michael Straube
2022-09-11 16:19 ` [PATCH 1/6] staging: r8188eu: rename odm_SignalScaleMapping() Michael Straube
2022-09-11 16:19 ` [PATCH 2/6] staging: r8188eu: clean up camel case in odm_signal_scale_mapping() Michael Straube
2022-09-11 16:19 ` Michael Straube [this message]
2022-09-11 16:19 ` [PATCH 4/6] staging: r8188eu: rename odm_QueryRxPwrPercentage() Michael Straube
2022-09-11 16:19 ` [PATCH 5/6] staging: r8188eu: clean up camel case in odm_query_rxpwrpercentage() Michael Straube
2022-09-11 16:19 ` [PATCH 6/6] staging: r8188eu: replace tabs with space " Michael Straube
2022-09-11 17:08 ` [PATCH 0/6] staging: r8188eu: some coding style cleanups Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220911161949.11293-4-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox