From: Nam Cao <namcaov@gmail.com>
To: Brent Pappas <pappasbrent@Knights.ucf.edu>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: most: net: Replace macros HB and LB with static inline functions
Date: Thu, 6 Oct 2022 01:57:28 +0200 [thread overview]
Message-ID: <20221005235728.GA118549@nam-dell> (raw)
In-Reply-To: <BN7PR07MB419563C5B405ED4082D7841DF65D9@BN7PR07MB4195.namprd07.prod.outlook.com>
On Wed, Oct 05, 2022 at 04:10:44PM +0000, Brent Pappas wrote:
> Replace function-like macros "HB" and "LB" with static inline functions
> to comply with preferred Linux coding style standards.
>
> Signed-off-by: Brent Pappas <pappasbrent@knights.ucf.edu>
> ---
> diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
> index 1d1fe8bff7ee..8a8fbc274b73 100644
> --- a/drivers/staging/most/net/net.c
> +++ b/drivers/staging/most/net/net.c
> @@ -36,8 +36,8 @@
> #define PMS_TELID_MASK 0x0F
> #define PMS_TELID_SHIFT 4
>
> -#define HB(value) ((u8)((u16)(value) >> 8))
> -#define LB(value) ((u8)(value))
> +static inline u8 HB(unsigned int value) { return ((u8)((u16)(value) >> 8)); }
> +static inline u8 LB(unsigned int value) { return ((u8)(value)); }
>
> #define EXTRACT_BIT_SET(bitset_name, value) \
> (((value) >> bitset_name##_SHIFT) & bitset_name##_MASK)
I cannot apply your patch. I think your email client modified some
whitespace characters.
Check this for more information:
https://www.kernel.org/doc/html/v4.10/process/email-clients.html
Best regards,
Nam
next prev parent reply other threads:[~2022-10-05 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:10 [PATCH] staging: most: net: Replace macros HB and LB with static inline functions Brent Pappas
2022-10-05 23:57 ` Nam Cao [this message]
2022-10-06 1:39 ` Brent Pappas
2022-10-06 13:21 ` Brent Pappas
2022-10-06 13:42 ` Nam Cao
2022-10-06 17:02 ` [PATCH v2] " Brent Pappas
2022-10-06 17:44 ` Nam Cao
2022-10-06 23:07 ` [PATCH v3] " Brent Pappas
2022-10-20 15:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005235728.GA118549@nam-dell \
--to=namcaov@gmail.com \
--cc=cai.huoqing@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pappasbrent@Knights.ucf.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox