From: Nam Cao <namcaov@gmail.com>
To: Rui Li <me@lirui.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: remove necessary braces for single statement blocks
Date: Sun, 9 Oct 2022 19:49:25 +0200 [thread overview]
Message-ID: <20221009174925.GA17573@nam-dell> (raw)
In-Reply-To: <166532561205.8.1223417525390189864.67805880@lirui.org>
On Sun, Oct 09, 2022 at 10:26:31PM +0800, Rui Li wrote:
> This commit cleans up checkpatch warning as follows:
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Rui Li <me@lirui.org>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 +++------
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ++++--------
> 3 files changed, 8 insertions(+), 16 deletions(-)
Greg expects a change log describing what has changed compared to the
last version. You should send a v3 with a changelog.
Additionally, did you mean "unnecessary" in the title?
Best regards,
Nam
next prev parent reply other threads:[~2022-10-09 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 14:26 [PATCH v2] staging: rtl8192e: remove necessary braces for single statement blocks Rui Li
2022-10-09 15:18 ` Christophe JAILLET
2022-10-09 17:49 ` Nam Cao [this message]
2022-10-09 18:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221009174925.GA17573@nam-dell \
--to=namcaov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@lirui.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).