From: Nam Cao <namcaov@gmail.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
Cc: greg@kroah.com, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: vt6655: Fix Lines should not end with a '('
Date: Thu, 20 Oct 2022 00:34:46 +0200 [thread overview]
Message-ID: <20221019223446.GA154747@nam-dell> (raw)
In-Reply-To: <Y1BN6wPMrpxPB3qP@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net>
On Wed, Oct 19, 2022 at 07:20:11PM +0000, Tanjuate Brunostar wrote:
> Code style warnings reported by checkpatch.
> Improve the layout of a function header:
> Put the first parameter immediately after the '(' and align the other
> parameters underneath it.
>
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
>
> ---
> v2: put static and void on the same line and adjusted the indentation as
> suggested by Greg KH
I think he meant putting "static" and "void" and also function name on
the same line.
Additionally, I think your patch introduces new checkpatch problems. Did
you run checkpatch.pl on your patch?
Best regards,
Nam
next prev parent reply other threads:[~2022-10-19 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 19:20 [PATCH v2] staging: vt6655: Fix Lines should not end with a '(' Tanjuate Brunostar
2022-10-19 22:34 ` Nam Cao [this message]
2022-10-20 10:15 ` Tanju Brunostar
2022-10-20 10:18 ` Julia Lawall
2022-10-20 10:29 ` Tanju Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019223446.GA154747@nam-dell \
--to=namcaov@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox