From: Kang Minchul <tegongkang@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Pavel Skripkin <paskripkin@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Kang Minchul <tegongkang@gmail.com>
Subject: [PATCH v2 3/4] staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit
Date: Mon, 24 Oct 2022 17:49:24 +0900 [thread overview]
Message-ID: <20221024084925.262289-4-tegongkang@gmail.com> (raw)
In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com>
Return 0 directly instead of storing it in a variable.
This can prevent cocci warning as follows:
Unneeded variable: "pull". Return "0" on line 298
Signed-off-by: Kang Minchul <tegongkang@gmail.com>
---
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
index 8e4a5acc0b18..6d1f56d1f9d7 100644
--- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
@@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw)
static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt)
{
- int pull = 0;
uint qsel;
u8 data_rate, pwr_status, offset;
struct adapter *adapt = pxmitframe->padapter;
@@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id);
rtl8188eu_cal_txdesc_chksum(ptxdesc);
- return pull;
+ return 0;
}
/* for non-agg data frame or management frame */
--
2.34.1
next prev parent reply other threads:[~2022-10-24 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 8:49 [PATCH v2 0/4] staging: r8188eu: cleaning up unused variables Kang Minchul
2022-10-24 8:49 ` [PATCH v2 1/4] staging: r8188eu: remove unnecessary variable in ioctl_linux Kang Minchul
2022-10-24 8:49 ` [PATCH v2 2/4] staging: r8188eu: make amsdu_to_msdu void function Kang Minchul
2022-10-24 12:49 ` kernel test robot
2022-10-24 8:49 ` Kang Minchul [this message]
2022-10-24 8:49 ` [PATCH v2 4/4] staging: r8188eu: remove unnecessary variable in rtw_ap Kang Minchul
2022-10-24 11:23 ` [PATCH v2 0/4] staging: r8188eu: cleaning up unused variables Kang Minchul
2022-10-25 17:22 ` Greg Kroah-Hartman
2022-10-25 17:33 ` Kang Minchul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024084925.262289-4-tegongkang@gmail.com \
--to=tegongkang@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox