From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev
Subject: [PATCH] staging: rtl8192e: use explicitly signed char
Date: Mon, 24 Oct 2022 18:30:05 +0200 [thread overview]
Message-ID: <20221024163005.536097-1-Jason@zx2c4.com> (raw)
With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. In this case, passing `char *extra` is part of the
iw API, and that extra is mostly intended to be somewhat opaque. So just
cast to `s8 *` for the sign test. This fixes warnings like:
drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index f9589c5b62ba..4563e3b5bd47 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -456,7 +456,7 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
}
for (i = 0; i < len; i++) {
- if (extra[i] < 0) {
+ if (((s8 *)extra)[i] < 0) {
ret = -1;
goto out;
}
--
2.38.1
next reply other threads:[~2022-10-24 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:30 Jason A. Donenfeld [this message]
2022-10-25 6:19 ` [PATCH] staging: rtl8192e: use explicitly signed char Dan Carpenter
2022-10-25 10:45 ` Greg Kroah-Hartman
2022-10-25 12:21 ` [PATCH v2] staging: rtl8192e: remove bogus ssid character sign test Jason A. Donenfeld
2022-10-25 12:34 ` Dan Carpenter
2022-10-25 17:35 ` Philipp Hortmann
2022-10-25 17:41 ` Greg KH
2022-10-25 17:43 ` Jason A. Donenfeld
2022-10-25 17:22 ` [PATCH] staging: rtl8192e: use explicitly signed char Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024163005.536097-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox