* [PATCH] staging: most: dim2: hal: aligning function parameters
@ 2022-10-26 11:06 UMWARI JOVIAL
2022-10-26 13:15 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: UMWARI JOVIAL @ 2022-10-26 11:06 UTC (permalink / raw)
To: gregkh, outreachy, linux-kernel, linux-staging
According to Linux Kernel Coding Style, lines should not end with a '('
Fix-issue reported by checkpatch.pl script.
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}
-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: most: dim2: hal: aligning function parameters
2022-10-26 11:06 [PATCH] staging: most: dim2: hal: aligning function parameters UMWARI JOVIAL
@ 2022-10-26 13:15 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-10-26 13:15 UTC (permalink / raw)
To: UMWARI JOVIAL; +Cc: outreachy, linux-kernel, linux-staging
On Wed, Oct 26, 2022 at 02:06:07PM +0300, UMWARI JOVIAL wrote:
> According to Linux Kernel Coding Style, lines should not end with a '('
> Fix-issue reported by checkpatch.pl script.
>
> Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> ---
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
You sent 2 copies of this, but I have no way to determine which one was
correct :(
Please resend a v2 only once so that we know which one is the one to
review.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: most: dim2: hal: aligning function parameters
@ 2022-10-26 10:56 UMWARI JOVIAL
0 siblings, 0 replies; 3+ messages in thread
From: UMWARI JOVIAL @ 2022-10-26 10:56 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel, Outreachy Linux
According to Linux Kernel Coding Style, lines should not end with a '('
Fix-issue reported by checkpatch.pl script.
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}
-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-26 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-26 11:06 [PATCH] staging: most: dim2: hal: aligning function parameters UMWARI JOVIAL
2022-10-26 13:15 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-10-26 10:56 UMWARI JOVIAL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox