From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F2C1C12; Wed, 26 Oct 2022 17:14:49 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id f27so12609012eje.1; Wed, 26 Oct 2022 10:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FRxHoxm6P1RvhdSeOwNej3/a2XKscd0zPEdZFSfHcAM=; b=fz5My3zIF5XGZhEoSzEVFDLGy9W8SAMCYayn36lNzsdTEetRLrOGWRE0KK72DXBjcB WF5v1NCWW97wXQx+n5jTNHG6VdRsSmaKekLetVYqPe/vPeFvqdnLslrO9DpFb7U6dCHv Tty1PsNwXDbNr3B+mgyJ92nHDEUkhv2fG9hlgKHXVifi91eVXIg22cjnAyAzuJOWxoYW 6441COwsIGhicA+ZgODplc2V4XGxhdlabztlCGBNOGZITC7tqHhKPYa4z7yeHfXgQpLO NjMNHR8fP8lsaTblgYpxxwYbj/y3o/gvZtP0kN32dT5OA4jB+67JYpkZBTMXoysYSONo TrNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FRxHoxm6P1RvhdSeOwNej3/a2XKscd0zPEdZFSfHcAM=; b=KMqAFxva8AHAFw4b4/eMYhyEMVbzUs7W+B2a/Gzs+egmEyjrZ+VmST1JReVzwF4LWg T/uKnA5RGIjQv07HsomvmBVhsYUmZv8gdFiN5h//PD0HHyRCR2HS+Z3e5nWkaoqpVJvE RTv93KTCwNW4revkDIi3zBbcVp9XcHdbJ/cr8soPZkaSdAbs0s0LjSy1hCFlvNhMXjzX tyave5ANVpSh0Cmo5z3fGK2xQ5XJNw58NgmDaaxZO1QVeP/dAN6zTVvNOFn64amYd5jm TbvWiXlvJkUABL/3WPCy/GvdC2LNzWYLx9pxUyMz8+bOOVod7UL+FisZ328yOK5Y4UUL lAHg== X-Gm-Message-State: ACrzQf3hntl6hI8qzK2T6iphwxp53Vkoqvn9TMGhRrA/IIxMdUxFqaXZ wATBEtY4pgKmnbbZHzenfmE= X-Google-Smtp-Source: AMsMyM6TgIXHjE8NpfTm6poMbr7co6qgf/WZMc46uMXEicr4AWS5WGVgfcxr6lLz/y58qzTitxtKZw== X-Received: by 2002:a17:907:7633:b0:7ad:85ee:c66d with SMTP id jy19-20020a170907763300b007ad85eec66dmr1477367ejc.730.1666804487769; Wed, 26 Oct 2022 10:14:47 -0700 (PDT) Received: from nam-dell (ip-217-105-46-178.ip.prioritytelecom.net. [217.105.46.178]) by smtp.gmail.com with ESMTPSA id b16-20020aa7cd10000000b00461bacee867sm3796683edw.25.2022.10.26.10.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 10:14:47 -0700 (PDT) Date: Wed, 26 Oct 2022 19:14:34 +0200 From: Nam Cao To: UMWARI JOVIAL Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer] Message-ID: <20221026171430.GA5592@nam-dell> References: <20221026132838.GA44037@rdm> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026132838.GA44037@rdm> On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > Using the checkpatch.pl script, found the below errors and fixed > ERROR: trailing whitespace > CHECK: Please don't use multiple blank lines > warning: braces around scalar initializer > > Signed-off-by: UMWARI JOVIAL > --- > drivers/staging/most/dim2/dim2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index 7a5f80e637a0..28259ce05024 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) > writel(0x04, dev->io_base + 0x600); > } > > - > /* BBCR = 0b11 */ > writel(0x03, dev->io_base + 0x500); > writel(0x0002FF02, dev->io_base + 0x508); > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { > { > .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > }, > - {}, I'm no expert, but this looks like a null terminator and probably should not be removed. Best regards, Nam