* [PATCH] staging: rtl8192e: cleanup coding style issues with spacing @ 2022-10-31 22:51 Jerom van der Sar 2022-10-31 23:07 ` Philipp Hortmann 0 siblings, 1 reply; 10+ messages in thread From: Jerom van der Sar @ 2022-10-31 22:51 UTC (permalink / raw) To: gregkh Cc: philip.g.hortmann, error27, linux-staging, linux-kernel, Jerom van der Sar Fixed several coding style issues in rtl_cam.c such as double blank lines and lack of spaces around binary operators. It passes without trivial warnings about spaces. Some other warnings still remain. Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> --- drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 25 +++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c index 41faeb4b9b9b..aeef735679db 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) { u32 ulcommand = 0; - ulcommand |= BIT31|BIT30; + ulcommand |= BIT31 | BIT30; rtl92e_writel(dev, RWCAM, ulcommand); } @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) SECR_value |= SCR_TxUseDK; } - ieee->hwsec_active = 1; if ((ieee->pHTInfo->iot_action & HT_IOT_ACT_PURE_N_MODE) || !hwwep) { ieee->hwsec_active = 0; @@ -100,33 +99,32 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, } if (DefaultKey) - usConfig |= BIT15 | (KeyType<<2); + usConfig |= BIT15 | (KeyType << 2); else - usConfig |= BIT15 | (KeyType<<2) | KeyIndex; - + usConfig |= BIT15 | (KeyType << 2) | KeyIndex; for (i = 0; i < CAM_CONTENT_COUNT; i++) { TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; - TargetCommand |= BIT31|BIT16; + TargetCommand |= BIT31 | BIT16; if (i == 0) { - TargetContent = (u32)(*(MacAddr+0)) << 16 | - (u32)(*(MacAddr+1)) << 24 | + TargetContent = (u32)(*(MacAddr + 0)) << 16 | + (u32)(*(MacAddr + 1)) << 24 | (u32)usConfig; rtl92e_writel(dev, WCAMI, TargetContent); rtl92e_writel(dev, RWCAM, TargetCommand); } else if (i == 1) { - TargetContent = (u32)(*(MacAddr+2)) | - (u32)(*(MacAddr+3)) << 8 | - (u32)(*(MacAddr+4)) << 16 | - (u32)(*(MacAddr+5)) << 24; + TargetContent = (u32)(*(MacAddr + 2)) | + (u32)(*(MacAddr + 3)) << 8 | + (u32)(*(MacAddr + 4)) << 16 | + (u32)(*(MacAddr + 5)) << 24; rtl92e_writel(dev, WCAMI, TargetContent); rtl92e_writel(dev, RWCAM, TargetCommand); } else { if (KeyContent != NULL) { rtl92e_writel(dev, WCAMI, - (u32)(*(KeyContent+i-2))); + (u32)(*(KeyContent + i - 2))); rtl92e_writel(dev, RWCAM, TargetCommand); udelay(100); } @@ -152,7 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { - for (EntryId = 0; EntryId < 4; EntryId++) { MacAddr = CAM_CONST_ADDR[EntryId]; if (priv->rtllib->swcamtable[EntryId].bused) { -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: rtl8192e: cleanup coding style issues with spacing 2022-10-31 22:51 [PATCH] staging: rtl8192e: cleanup coding style issues with spacing Jerom van der Sar @ 2022-10-31 23:07 ` Philipp Hortmann 2022-11-01 21:52 ` [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c Jerom van der Sar 0 siblings, 1 reply; 10+ messages in thread From: Philipp Hortmann @ 2022-10-31 23:07 UTC (permalink / raw) To: Jerom van der Sar, gregkh Cc: philip.g.hortmann, error27, linux-staging, linux-kernel On 10/31/22 23:51, Jerom van der Sar wrote: > Fixed several coding style issues in rtl_cam.c such as double blank lines > and lack of spaces around binary operators. It passes without trivial > warnings about spaces. Some other warnings still remain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 25 +++++++++------------ > 1 file changed, 11 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..aeef735679db 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30; > rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) > SECR_value |= SCR_TxUseDK; > } > > - > ieee->hwsec_active = 1; > if ((ieee->pHTInfo->iot_action & HT_IOT_ACT_PURE_N_MODE) || !hwwep) { > ieee->hwsec_active = 0; > @@ -100,33 +99,32 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, > } > > if (DefaultKey) > - usConfig |= BIT15 | (KeyType<<2); > + usConfig |= BIT15 | (KeyType << 2); > else > - usConfig |= BIT15 | (KeyType<<2) | KeyIndex; > - > + usConfig |= BIT15 | (KeyType << 2) | KeyIndex; > > for (i = 0; i < CAM_CONTENT_COUNT; i++) { > TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; > - TargetCommand |= BIT31|BIT16; > + TargetCommand |= BIT31 | BIT16; > > if (i == 0) { > - TargetContent = (u32)(*(MacAddr+0)) << 16 | > - (u32)(*(MacAddr+1)) << 24 | > + TargetContent = (u32)(*(MacAddr + 0)) << 16 | > + (u32)(*(MacAddr + 1)) << 24 | > (u32)usConfig; > > rtl92e_writel(dev, WCAMI, TargetContent); > rtl92e_writel(dev, RWCAM, TargetCommand); > } else if (i == 1) { > - TargetContent = (u32)(*(MacAddr+2)) | > - (u32)(*(MacAddr+3)) << 8 | > - (u32)(*(MacAddr+4)) << 16 | > - (u32)(*(MacAddr+5)) << 24; > + TargetContent = (u32)(*(MacAddr + 2)) | > + (u32)(*(MacAddr + 3)) << 8 | > + (u32)(*(MacAddr + 4)) << 16 | > + (u32)(*(MacAddr + 5)) << 24; > rtl92e_writel(dev, WCAMI, TargetContent); > rtl92e_writel(dev, RWCAM, TargetCommand); > } else { > if (KeyContent != NULL) { > rtl92e_writel(dev, WCAMI, > - (u32)(*(KeyContent+i-2))); > + (u32)(*(KeyContent + i - 2))); > rtl92e_writel(dev, RWCAM, TargetCommand); > udelay(100); > } > @@ -152,7 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) > > if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || > (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { > - > for (EntryId = 0; EntryId < 4; EntryId++) { > MacAddr = CAM_CONST_ADDR[EntryId]; > if (priv->rtllib->swcamtable[EntryId].bused) { Text from greg k-h's patch email bot: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. Comment PH: Try one simple patch first and then increase. Do not start with a series if you do not have any experience. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. Bye Philipp ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-10-31 23:07 ` Philipp Hortmann @ 2022-11-01 21:52 ` Jerom van der Sar 2022-11-01 22:07 ` Philipp Hortmann 0 siblings, 1 reply; 10+ messages in thread From: Jerom van der Sar @ 2022-11-01 21:52 UTC (permalink / raw) To: gregkh Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel, Jerom van der Sar Fixed a few coding style issues in rtl_cam.c such as double blank lines and lack of spaces around binary operators. Some other warnings still remain. These issues were found by scripts/checkpatch.pl. This patch helps clean up the rtl8192e driver in staging, making it easier to read and maintain. Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com>. --- Changes in v2: - Reverted some formatting fixes to make the diff easier to review. drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c index 41faeb4b9b9b..d5aaf24a0ddb 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) { u32 ulcommand = 0; - ulcommand |= BIT31|BIT30; + ulcommand |= BIT31 | BIT30; rtl92e_writel(dev, RWCAM, ulcommand); } @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) SECR_value |= SCR_TxUseDK; } - ieee->hwsec_active = 1; if ((ieee->pHTInfo->iot_action & HT_IOT_ACT_PURE_N_MODE) || !hwwep) { ieee->hwsec_active = 0; @@ -104,10 +103,9 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, else usConfig |= BIT15 | (KeyType<<2) | KeyIndex; - for (i = 0; i < CAM_CONTENT_COUNT; i++) { TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; - TargetCommand |= BIT31|BIT16; + TargetCommand |= BIT31 | BIT16; if (i == 0) { TargetContent = (u32)(*(MacAddr+0)) << 16 | @@ -152,7 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { - for (EntryId = 0; EntryId < 4; EntryId++) { MacAddr = CAM_CONST_ADDR[EntryId]; if (priv->rtllib->swcamtable[EntryId].bused) { -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-01 21:52 ` [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c Jerom van der Sar @ 2022-11-01 22:07 ` Philipp Hortmann 2022-11-01 22:25 ` Jerom van der Sar 2022-11-01 22:29 ` [PATCH v3] " Jerom van der Sar 0 siblings, 2 replies; 10+ messages in thread From: Philipp Hortmann @ 2022-11-01 22:07 UTC (permalink / raw) To: Jerom van der Sar, gregkh; +Cc: error27, linux-staging, linux-kernel On 11/1/22 22:52, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c such as double blank lines > and lack of spaces around binary operators. Some other warnings still > remain. These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com>. > --- > Changes in v2: > - Reverted some formatting fixes to make the diff easier to review. > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..d5aaf24a0ddb 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30; > rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) > SECR_value |= SCR_TxUseDK; > } > > - > ieee->hwsec_active = 1; > if ((ieee->pHTInfo->iot_action & HT_IOT_ACT_PURE_N_MODE) || !hwwep) { > ieee->hwsec_active = 0; > @@ -104,10 +103,9 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, > else > usConfig |= BIT15 | (KeyType<<2) | KeyIndex; > > - > for (i = 0; i < CAM_CONTENT_COUNT; i++) { > TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; > - TargetCommand |= BIT31|BIT16; > + TargetCommand |= BIT31 | BIT16; > > if (i == 0) { > TargetContent = (u32)(*(MacAddr+0)) << 16 | > @@ -152,7 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) > > if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || > (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { > - > for (EntryId = 0; EntryId < 4; EntryId++) { > MacAddr = CAM_CONST_ADDR[EntryId]; > if (priv->rtllib->swcamtable[EntryId].bused) { WARNING: Unexpected content after email: 'Jerom van der Sar <jerom.vandersar@gmail.com>.', should be: 'Jerom van der Sar <jerom.vandersar@gmail.com>' #14: Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com>. I cannot apply your patch. Bye Philipp ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-01 22:07 ` Philipp Hortmann @ 2022-11-01 22:25 ` Jerom van der Sar 2022-11-01 22:29 ` [PATCH v3] " Jerom van der Sar 1 sibling, 0 replies; 10+ messages in thread From: Jerom van der Sar @ 2022-11-01 22:25 UTC (permalink / raw) To: gregkh; +Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel On 11/1/22 23:11, Philipp Hortman wrote: > WARNING: Unexpected content after email: 'Jerom van der Sar > <jerom.vandersar@gmail.com>.', should be: 'Jerom van der Sar > <jerom.vandersar@gmail.com>' > #14: > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com>. > > > I cannot apply your patch. > > Bye Philipp Thanks for the catch. Will fix. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-01 22:07 ` Philipp Hortmann 2022-11-01 22:25 ` Jerom van der Sar @ 2022-11-01 22:29 ` Jerom van der Sar 2022-11-02 7:24 ` Greg KH 1 sibling, 1 reply; 10+ messages in thread From: Jerom van der Sar @ 2022-11-01 22:29 UTC (permalink / raw) To: gregkh Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel, Jerom van der Sar Fixed a few coding style issues in rtl_cam.c such as double blank lines and lack of spaces around binary operators.Some other warnings still remain. These issues were found by scripts/checkpatch.pl. This patch helps clean up the rtl8192e driver in staging, making it easier to read and maintain. Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> --- Changes in v3: - Fixed faulty dot at the end of the patch sign-off. Changes in v2: - Reverted some formatting fixes to make the diff easier to review. drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c index 41faeb4b9b9b..d5aaf24a0ddb 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) { u32 ulcommand = 0; - ulcommand |= BIT31|BIT30; + ulcommand |= BIT31 | BIT30; rtl92e_writel(dev, RWCAM, ulcommand); } @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) SECR_value |= SCR_TxUseDK; } - ieee->hwsec_active = 1; if ((ieee->pHTInfo->iot_action & HT_IOT_ACT_PURE_N_MODE) || !hwwep) { ieee->hwsec_active = 0; @@ -104,10 +103,9 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, else usConfig |= BIT15 | (KeyType<<2) | KeyIndex; - for (i = 0; i < CAM_CONTENT_COUNT; i++) { TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; - TargetCommand |= BIT31|BIT16; + TargetCommand |= BIT31 | BIT16; if (i == 0) { TargetContent = (u32)(*(MacAddr+0)) << 16 | @@ -152,7 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { - for (EntryId = 0; EntryId < 4; EntryId++) { MacAddr = CAM_CONST_ADDR[EntryId]; if (priv->rtllib->swcamtable[EntryId].bused) { -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-01 22:29 ` [PATCH v3] " Jerom van der Sar @ 2022-11-02 7:24 ` Greg KH 2022-11-02 20:00 ` [PATCH v4] " Jerom van der Sar 0 siblings, 1 reply; 10+ messages in thread From: Greg KH @ 2022-11-02 7:24 UTC (permalink / raw) To: Jerom van der Sar Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel On Tue, Nov 01, 2022 at 11:29:00PM +0100, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c such as double blank lines > and lack of spaces around binary operators.Some other warnings still > remain. These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > Changes in v3: > - Fixed faulty dot at the end of the patch sign-off. > > Changes in v2: > - Reverted some formatting fixes to make the diff easier to review. > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..d5aaf24a0ddb 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30; Ok, new spaces, nice! > rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) > SECR_value |= SCR_TxUseDK; > } > > - You removed a line? That's a different type of fix, sorry. Please break this up into a "one logical change per patch" patch series and resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-02 7:24 ` Greg KH @ 2022-11-02 20:00 ` Jerom van der Sar 2022-11-02 22:00 ` Philipp Hortmann 2022-11-08 15:21 ` Greg KH 0 siblings, 2 replies; 10+ messages in thread From: Jerom van der Sar @ 2022-11-02 20:00 UTC (permalink / raw) To: gregkh Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel, Jerom van der Sar Fixed a few coding style issues in rtl_cam.c: two times lack of spaces around binary operators. Some other warnings still remain. These issues were found by scripts/checkpatch.pl. This patch helps clean up the rtl8192e driver in staging, making it easier to read and maintain. Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> --- Changes in v4: - Reverted more double blank line formatting fixes to make the patch even smaller. Changes in v3: - Fixed faulty dot at the end of the patch sign-off. Changes in v2: - Reverted some formatting fixes to make the diff easier to review. drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c index 41faeb4b9b9b..41bff46d1b3a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) { u32 ulcommand = 0; - ulcommand |= BIT31|BIT30; + ulcommand |= BIT31 | BIT30; rtl92e_writel(dev, RWCAM, ulcommand); } @@ -107,7 +107,7 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, for (i = 0; i < CAM_CONTENT_COUNT; i++) { TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; - TargetCommand |= BIT31|BIT16; + TargetCommand |= BIT31 | BIT16; if (i == 0) { TargetContent = (u32)(*(MacAddr+0)) << 16 | -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-02 20:00 ` [PATCH v4] " Jerom van der Sar @ 2022-11-02 22:00 ` Philipp Hortmann 2022-11-08 15:21 ` Greg KH 1 sibling, 0 replies; 10+ messages in thread From: Philipp Hortmann @ 2022-11-02 22:00 UTC (permalink / raw) To: Jerom van der Sar, gregkh; +Cc: error27, linux-staging, linux-kernel On 11/2/22 21:00, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c: two times lack of > spaces around binary operators. Some other warnings still remain. > These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > Changes in v4: > - Reverted more double blank line formatting fixes to make the patch > even smaller. > > Changes in v3: > - Fixed faulty dot at the end of the patch sign-off. > > Changes in v2: > - Reverted some formatting fixes to make the diff easier to review. > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..41bff46d1b3a 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30; > rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -107,7 +107,7 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, > > for (i = 0; i < CAM_CONTENT_COUNT; i++) { > TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; > - TargetCommand |= BIT31|BIT16; > + TargetCommand |= BIT31 | BIT16; > > if (i == 0) { > TargetContent = (u32)(*(MacAddr+0)) << 16 | Please rebase. I cannot apply your patch. Bye Philipp ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] staging: rtl8192e: space formatting fixes in rtl_cam.c 2022-11-02 20:00 ` [PATCH v4] " Jerom van der Sar 2022-11-02 22:00 ` Philipp Hortmann @ 2022-11-08 15:21 ` Greg KH 1 sibling, 0 replies; 10+ messages in thread From: Greg KH @ 2022-11-08 15:21 UTC (permalink / raw) To: Jerom van der Sar Cc: philipp.g.hortmann, error27, linux-staging, linux-kernel On Wed, Nov 02, 2022 at 09:00:58PM +0100, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c: two times lack of > spaces around binary operators. Some other warnings still remain. > These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > Changes in v4: > - Reverted more double blank line formatting fixes to make the patch > even smaller. Does not apply to my tree :( ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-11-08 15:21 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-31 22:51 [PATCH] staging: rtl8192e: cleanup coding style issues with spacing Jerom van der Sar 2022-10-31 23:07 ` Philipp Hortmann 2022-11-01 21:52 ` [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c Jerom van der Sar 2022-11-01 22:07 ` Philipp Hortmann 2022-11-01 22:25 ` Jerom van der Sar 2022-11-01 22:29 ` [PATCH v3] " Jerom van der Sar 2022-11-02 7:24 ` Greg KH 2022-11-02 20:00 ` [PATCH v4] " Jerom van der Sar 2022-11-02 22:00 ` Philipp Hortmann 2022-11-08 15:21 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).