Re: [PATCH 02/23] dt-bindings: display: tegra: vi: add 'vip' property and example

Krzysztof Kozlowski
2022-11-15T12:15:36Z

On 09/11/2022 15:18, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> The Tegra20 VI peripheral can receive parallel input from the VIP parallel
> input module. Add it to the allowed properties and augment the existing
> nvidia,tegra20-vi example to show a 'vip' property.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> .../display/tegra/nvidia,tegra20-vi.yaml | 68 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 69 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml
> index 782a4b10150a..aab795241dd6 100644
> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml
> @@ -74,6 +74,22 @@ properties:
> avdd-dsi-csi-supply:
> description: DSI/CSI power supply. Must supply 1.2 V.
>
> + vip:
> + $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Input from the VIP (parallel input capture) module
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/properties/endpoint
> +
> patternProperties:
> "^csi@[0-9a-f]+$":
> type: object
> @@ -109,6 +125,22 @@ examples:
> #include <dt-bindings/clock/tegra20-car.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> + i2c3 {

Just "i2c"

With above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof