Re: [PATCH 01/23] dt-bindings: display: tegra: add bindings for Tegra20 VIP

Krzysztof Kozlowski
2022-11-15T12:12:48Z

On 09/11/2022 15:18, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> VIP is the parallel video capture component within the video input
> subsystem of Tegra20 (and other Tegra chips, apparently).

Subject: drop second, redundant "bindings".

>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> .../display/tegra/nvidia,tegra20-vip.yaml | 64 +++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
> new file mode 100644
> index 000000000000..934dabfd2307
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/tegra/nvidia,tegra20-vip.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra VIP (parallel video capture) controller
> +
> +maintainers:
> + - Luca Ceresoli <luca.ceresoli@bootlin.com>
> +
> +properties:
> + $nodename:
> + const: vip

No need to enforce names in device schemas, especially that this does
not look like a generic name.

> +
> + compatible:
> + enum:
> + - nvidia,tegra20-vip
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + channel@0:

Missing description.

> + type: object

Do you expect it to grow to more channels?

> +
> + properties:
> + reg: true

const: 0

> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Port receiving the video stream from the sensor
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Port sending the video stream to the VI
> +
> + required:
> + - port@0
> + - port@1
> +
> + additionalProperties: false
> +
> + required:
> + - reg
> + - ports
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> + - channel@0
> +
> +# see nvidia,tegra20-vi.yaml for an example

That file does not have this compatible. At least not on next-20221109.

Best regards,
Krzysztof