From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5EA1107A0 for ; Thu, 1 Dec 2022 23:16:38 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id m204so3687497oib.6 for ; Thu, 01 Dec 2022 15:16:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gNRL/xeucB6+OrmUshP7jeXkdDiSosMVb1WPEhPiXKc=; b=JLXcECLlRPbSuvIZdtUwo+VaE/mkE8ItRalzBVE5ABN8Fu5r8JvHAfloaC8Kckke4R qccMGhKg9FqRxD7gQpWVmMZ0UapfSVktSNiPgqVBR8gPNS4YTbtONKzupS/xwwzBZT3u VW69XDAZgaiWirZwfZzL5u2aFNks04gY2IOprsrFMrGdBQWoIZtWUlW5NUtyIuAa44nG Snc9DCFsLih5G6Stv4rCRNbMXqxK0sUMXl5JjB/cJb1aoB/IhYDGbtCqbWLL4AnH4u/A pZcyhuJak0U2ZqJbwU93Wqplnk8PRzLMfJ9rNeGx9qPJZCCsv5+Y9VY1wy81m/MRzKIh JWpQ== X-Gm-Message-State: ANoB5pkA8DAjhGviZPwK4ssv1bdYTRb5DJ2BEfVleSZZa3FrsxpKlvgq tWWWDHH6+UpDBRX38fzp0Q== X-Google-Smtp-Source: AA0mqf6muhWWfnkoFwIXqCBePQ/MBBdAE6jdhns/DS7Zug2GZHo7VgeRSyRh9WVHfv7OuXgP60TIFQ== X-Received: by 2002:a05:6808:648:b0:35a:1139:37fb with SMTP id z8-20020a056808064800b0035a113937fbmr25391098oih.158.1669936597744; Thu, 01 Dec 2022 15:16:37 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a7-20020a9d4707000000b0066e7e4b2f76sm430735otf.17.2022.12.01.15.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:16:37 -0800 (PST) Received: (nullmailer pid 1663520 invoked by uid 1000); Thu, 01 Dec 2022 23:16:36 -0000 Date: Thu, 1 Dec 2022 17:16:36 -0600 From: Rob Herring To: Luca Ceresoli Cc: David Airlie , Daniel Vetter , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dmitry Osipenko , Hans Verkuil , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Thomas Petazzoni , Paul Kocialkowski , Richard Leitner , Krzysztof Kozlowski Subject: Re: [PATCH v2 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example Message-ID: <20221201231636.GA1660613-robh@kernel.org> References: <20221128152336.133953-1-luca.ceresoli@bootlin.com> <20221128152336.133953-3-luca.ceresoli@bootlin.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128152336.133953-3-luca.ceresoli@bootlin.com> On Mon, Nov 28, 2022 at 04:23:17PM +0100, Luca Ceresoli wrote: > The Tegra20 VI peripheral can receive parallel input from the VIP parallel > input module. Add it to the allowed properties and augment the existing > nvidia,tegra20-vi example to show a 'vip' property. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Luca Ceresoli > > --- > > Changed in v2 (suggested by Krzysztof Kozlowski): > - rename "i2c3" -> "ic2" > - add review tag > --- > .../display/tegra/nvidia,tegra20-vi.yaml | 68 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > index 782a4b10150a..5b5583c2b562 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > @@ -74,6 +74,22 @@ properties: > avdd-dsi-csi-supply: > description: DSI/CSI power supply. Must supply 1.2 V. > > + vip: > + $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input from the VIP (parallel input capture) module > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/properties/endpoint You can drop 'endpoint'. You only need port nodes if there's no extra properties in the endpoints. > + > patternProperties: > "^csi@[0-9a-f]+$": > type: object > @@ -109,6 +125,22 @@ examples: > #include > #include > > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + camera@48 { > + compatible = "aptina,mt9v111"; > + reg = <0x48>; > + clocks = <&camera_clk>; > + > + port { > + mt9v111_out: endpoint { > + remote-endpoint = <&vi_vip_in>; > + }; > + }; > + }; > + }; > + > vi@54080000 { > compatible = "nvidia,tegra20-vi"; > reg = <0x54080000 0x00040000>; > @@ -116,6 +148,42 @@ examples: > clocks = <&tegra_car TEGRA20_CLK_VI>; > resets = <&tegra_car 100>; > reset-names = "vi"; > + > + vip { > + compatible = "nvidia,tegra20-vip"; > + #address-cells = <1>; > + #size-cells = <0>; > + channel@0 { > + reg = <0>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + vi_vip_in: endpoint { > + remote-endpoint = <&mt9v111_out>; > + }; > + }; > + port@1 { > + reg = <1>; > + vi_vip_out: endpoint { > + remote-endpoint = <&vi_in>; > + }; > + }; > + }; > + }; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + vi_in: endpoint { > + remote-endpoint = <&vi_vip_out>; > + }; > + }; > + }; > }; > > - | > diff --git a/MAINTAINERS b/MAINTAINERS > index 92c762f85f17..0c97ce22735d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20320,6 +20320,7 @@ M: Luca Ceresoli > L: linux-media@vger.kernel.org > L: linux-tegra@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml > > TEGRA XUSB PADCTL DRIVER > -- > 2.34.1 > >