From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E921109 for ; Wed, 28 Dec 2022 10:54:40 +0000 (UTC) Received: from relay11.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::231]) by mslow1.mail.gandi.net (Postfix) with ESMTP id C4AF0C8404 for ; Wed, 28 Dec 2022 10:46:28 +0000 (UTC) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 256A0100008; Wed, 28 Dec 2022 10:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1672224381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPhB9YD5mKOaUrJH3XDFS7rFqV5FxdGCchYtk5MvfdE=; b=gk9JkWgOOMenYieQG9suTpj/sWfHBXPuyGHmqeqY66hups8+Neu2LVN43A1VAhCQHUFofk uG9AqJCE4tB2g/X4CTP2BakPuvtGnG90jIICszUiepR1pcbSK2l582jTUYM61zasFqULXV zYOo9SX57Dc1RL5jh5uhU2CaimRU3J5nmXG0c14i58oQ3mNKoROPWc21ACoS/+Uz/0jbte xJUe/GIimcX6tRPn1V7yHIjb65w1zpMpOHfAjXVft0iQS17PaWZ2bfCbUUB7sGSGECoyG9 ms+XQ4sf8ntTeSWqBkLByj+VMb31nU0U/CbaVhvrR6Mq5NHcKId4Vituw1OFeQ== Date: Wed, 28 Dec 2022 11:46:17 +0100 From: Luca Ceresoli To: Dmitry Osipenko Cc: David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Thomas Petazzoni , Paul Kocialkowski , Richard Leitner Subject: Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant Message-ID: <20221228114617.397cba35@booty> In-Reply-To: <44d2d972-1cdf-fdb2-5dc0-cc493f79b3da@gmail.com> References: <20221128152336.133953-1-luca.ceresoli@bootlin.com> <20221128152336.133953-22-luca.ceresoli@bootlin.com> <44d2d972-1cdf-fdb2-5dc0-cc493f79b3da@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 23 Dec 2022 15:35:58 +0300 Dmitry Osipenko wrote: > 28.11.2022 18:23, Luca Ceresoli =D0=BF=D0=B8=D1=88=D0=B5=D1=82: ... > > +static const struct tegra_vip_ops tegra20_vip_ops =3D { > > + .vip_start_streaming =3D tegra20_vip_start_streaming, > > +}; > > + > > +const struct tegra_vip_soc tegra20_vip_soc =3D { > > + .ops =3D &tegra20_vip_ops, > > +}; =20 >=20 > Shouldn't this be placed in vip.c? Indeed. Which means tegra210_csi_soc can be moved as well, so I'm adding a small patch to the series to do that. > Also looks like patch #20 won't link > because tegra20_vip_soc is defined in patch #21. You're right, we have a chicken-egg problem here. One solution would be leaving tegra_vip_of_id_table empty in patch 20 and fill it only in patch 21, but that would not be bisectable as patch 20 would introduce code that nobody uses until patch 21. So I think it's better to squash together patches 20+21. --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com