From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC4DA2C80 for ; Wed, 8 Feb 2023 14:33:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BA0FC433EF; Wed, 8 Feb 2023 14:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675866815; bh=nWey4jNU9+Sif+LSgRMsMxWM4RnLU+cpOsDgXGewWQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bxr6yBG2Sc2qJ8swG0K4FZBoRaWDOrxNOV4/Ljrof1okbjOBp9ODwtSnL5XEYUT3T dABWfhz1D35ipFx685szlb3KLiBQicaVpLNMMGwwdHGnixiNWNI58cw5Opmab4DEzx tN+KhRI6t277jpdWddIWGhFLtz/WtmWcr7FNpi9HGbNWa+XeSmth43M5xPsb3wnOKI 8s/Wv3W5YYzuR8WkIKgISlnWdpjOGJPxjel9cu0qRimAdSJjrSHh7kjB3SKed6UUcR rRLFQ74JJ3gCyfIpYi9fl9kvIrBNax1zudQ06Ol8WvwxrxIZ/BZgOZwidQ40ANHvr4 cMl5I248ST+Eg== Date: Wed, 8 Feb 2023 15:33:29 +0100 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: Hans de Goede , Tsuchiya Yuto , Andy Shevchenko , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 28/57] media: Add ovxxxx_16bit_addr_reg_helpers.h Message-ID: <20230208153329.6dccd807@coco.lan> In-Reply-To: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-29-hdegoede@redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Wed, 8 Feb 2023 13:31:17 +0200 Sakari Ailus escreveu: > Hi Hans, > > On Mon, Jan 23, 2023 at 01:51:36PM +0100, Hans de Goede wrote: > > The following drivers under drivers/media/i2c: ov08x40.c, ov13858.c, > > ov13b10.c, ov2680.c, ov2685.c, ov2740.c, ov4689.c, ov5670.c, > > ov5675.c, ov5695.c, ov8856.c, ov9282.c and ov9734.c, > > > > as well as various "atomisp" sensor drivers in drivers/staging, *all* > > use register access helpers with the following function prototypes: > > > > int ovxxxx_read_reg(struct ovxxxx_dev *sensor, u16 reg, > > unsigned int len, u32 *val); > > > > int ovxxxx_write_reg(struct ovxxxx_dev *sensor, u16 reg, > > unsigned int len, u32 val); > > > > To read/write registers on Omnivision OVxxxx image sensors wich expect > > a 16 bit register address in big-endian format and which have 1-3 byte > > wide registers, in big-endian format (for the higher width registers). > > > > Add a new ovxxxx_16bit_addr_reg_helpers.h header file with static inline > > versions of these register access helpers, so that this code duplication > > can be removed. > > Ideally we'd have helpers for CCI, of which this is a subset. And on top of > regmap. I don't object adding these either though. Well, ideally, when the atomisp-specific sensor ioctls go away, we can merge the atomisp-specific sensor drivers for not-yet-uptreamed sensors or modify the existing sensor drivers to accept the atomisp resolutions [1]. So, for now, I wouldn't convert those to use regmap. This can be done later with the remaining drivers. [1] atomisp usually requires 16 extra lines/columns for it to work, so the current sensor drivers there allow setting resolutions like 1616x1216 at the sensor, while offering 1600x1200 resolution to userspace. Thanks, Mauro