From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972D8568A; Sat, 25 Mar 2023 21:33:32 +0000 (UTC) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 605458BE; Sat, 25 Mar 2023 22:33:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679780010; bh=Y6nQUcxsMUEaLqFYKd5Cw8gbyXuuUb2Ob4ctiSEQ+mk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F6gTpVIz0XFThyxKyCyXBI8ptYpMSvsCt+wjSsvDYGUwcKZwY3KklV2irQVXhsShl ild0bS5259NBrDKhIXUEjz6G5fRsGj7ziXDPhWVM7BBgV5Fco4dnjaexzNbFwaUjzr HjhIgDc788NZWqP1v8kdDuOtzqOxCL9JBhyyQyoI= Date: Sat, 25 Mar 2023 23:33:36 +0200 From: Laurent Pinchart To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Adam Pigg , Thomas Petazzoni Subject: Re: [PATCH 7/9] media: sun6i-csi: capture: Implement enum_framesizes Message-ID: <20230325213336.GE22214@pendragon.ideasonboard.com> References: <20230324151228.2778112-1-paul.kocialkowski@bootlin.com> <20230324151228.2778112-8-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230324151228.2778112-8-paul.kocialkowski@bootlin.com> Hi Paul, Thank you for the patch. On Fri, Mar 24, 2023 at 04:12:26PM +0100, Paul Kocialkowski wrote: > Report available frame sizes as a continuous range between the > hardware min/max limits. > > Signed-off-by: Paul Kocialkowski > Co-authored-by: Adam Pigg > Signed-off-by: Adam Pigg Reviewed-by: Laurent Pinchart > --- > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > index 9627030ff060..31ba83014086 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > @@ -847,6 +847,30 @@ static int sun6i_csi_capture_try_fmt(struct file *file, void *private, > return 0; > } > > +static int > +sun6i_csi_capture_enum_framesizes(struct file *file, void *fh, > + struct v4l2_frmsizeenum *frmsizeenum) > +{ > + const struct sun6i_csi_capture_format *format; > + > + if (frmsizeenum->index > 0) > + return -EINVAL; > + > + format = sun6i_csi_capture_format_find(frmsizeenum->pixel_format); > + if (!format) > + return -EINVAL; > + > + frmsizeenum->type = V4L2_FRMSIZE_TYPE_CONTINUOUS; > + frmsizeenum->stepwise.min_width = SUN6I_CSI_CAPTURE_WIDTH_MIN; > + frmsizeenum->stepwise.max_width = SUN6I_CSI_CAPTURE_WIDTH_MAX; > + frmsizeenum->stepwise.min_height = SUN6I_CSI_CAPTURE_HEIGHT_MIN; > + frmsizeenum->stepwise.max_height = SUN6I_CSI_CAPTURE_HEIGHT_MAX; > + frmsizeenum->stepwise.step_width = 1; > + frmsizeenum->stepwise.step_height = 1; > + > + return 0; > +} > + > static int sun6i_csi_capture_enum_input(struct file *file, void *private, > struct v4l2_input *input) > { > @@ -884,6 +908,8 @@ static const struct v4l2_ioctl_ops sun6i_csi_capture_ioctl_ops = { > .vidioc_s_fmt_vid_cap = sun6i_csi_capture_s_fmt, > .vidioc_try_fmt_vid_cap = sun6i_csi_capture_try_fmt, > > + .vidioc_enum_framesizes = sun6i_csi_capture_enum_framesizes, > + > .vidioc_enum_input = sun6i_csi_capture_enum_input, > .vidioc_g_input = sun6i_csi_capture_g_input, > .vidioc_s_input = sun6i_csi_capture_s_input, -- Regards, Laurent Pinchart