From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BAED1841 for ; Sat, 8 Apr 2023 11:29:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 456E3C433D2; Sat, 8 Apr 2023 11:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680953363; bh=3hCUEw4+sq86IrKsrawaMlZ/p+hC7wvYN9WX4oBCENs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zty+tYDanBiDXGRzHxC0jelAYSRHyLIyaHWQs6SIIuIhblUf6u24ZpRowl/HM4CN9 xURvUPcdeJeCgE+iNpxnlJqwU2Uj/vYbLtDG7ot0IL+OIEqjkfv25nd3NwQY/i1gzH SHG8lao4dg5ZakDy2EGpCPQhI3024xorut+dd744= Date: Sat, 8 Apr 2023 13:29:20 +0200 From: Greg KH To: Dalvin-Ehinoma Noah Aiguobas Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon: remove typedef declaration for enums Message-ID: <2023040806-revise-tiptoeing-81a3@gregkh> References: <20230407130543.GA32964@koolguy> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230407130543.GA32964@koolguy> On Fri, Apr 07, 2023 at 03:05:43PM +0200, Dalvin-Ehinoma Noah Aiguobas wrote: > Fix checkpatch.pl warning for enums in drivers/staging/octeon/octeon-stubs.h: > cvmx_helper_interface_mode_t, > cvmx_spi_mode_t, > cvmx_pow_wait_t, > cvmx_pko_lock_t, > cvmx_pko_status_t > > Change typedef cvmx_helper_interface_mode_t to > enum cvmx_helper_interface_mode in ethernet.c > > Signed-off-by: Dalvin-Ehinoma Noah Aiguobas > --- > drivers/staging/octeon/ethernet.c | 2 +- > drivers/staging/octeon/octeon-stubs.h | 50 +++++++++++++++------------ > 2 files changed, 29 insertions(+), 23 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot