* [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis
@ 2023-04-08 16:51 Sumitra Sharma
2023-04-15 15:54 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Sumitra Sharma @ 2023-04-08 16:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel
Fix alignment to match opening parenthesis as suggested by Linux kernel
coding-style. This issue is reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index cde41111012a..d0b943145259 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -564,11 +564,9 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(struct net_device *dev)
for (k = 0; k < 5; k++) {
if (k != 4)
- tmp_report[k] = rtl92e_readb(dev,
- Tssi_Report_Value1+k);
+ tmp_report[k] = rtl92e_readb(dev, Tssi_Report_Value1+k);
else
- tmp_report[k] = rtl92e_readb(dev,
- Tssi_Report_Value2);
+ tmp_report[k] = rtl92e_readb(dev, Tssi_Report_Value2);
if (tmp_report[k] <= 20) {
viviflag = true;
@@ -1138,7 +1136,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev)
return;
if (priv->undecorated_smoothed_pwdb <= dm_digtable.rssi_low_thresh) {
if (dm_digtable.dig_state == DM_STA_DIG_OFF &&
- (priv->reset_count == reset_cnt))
+ (priv->reset_count == reset_cnt))
return;
reset_cnt = priv->reset_count;
@@ -1216,7 +1214,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev)
if (priv->undecorated_smoothed_pwdb >=
dm_digtable.rssi_high_power_highthresh) {
if (dm_digtable.dig_highpwr_state == DM_STA_DIG_ON &&
- (priv->reset_count == reset_cnt_highpwr))
+ (priv->reset_count == reset_cnt_highpwr))
return;
dm_digtable.dig_highpwr_state = DM_STA_DIG_ON;
@@ -1226,7 +1224,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev)
rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x43);
} else {
if (dm_digtable.dig_highpwr_state == DM_STA_DIG_OFF &&
- (priv->reset_count == reset_cnt_highpwr))
+ (priv->reset_count == reset_cnt_highpwr))
return;
dm_digtable.dig_highpwr_state = DM_STA_DIG_OFF;
@@ -2111,9 +2109,8 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)
} else if (priv->undecorated_smoothed_pwdb >=
(RegC38_TH+5)) {
if (reg_c38_State) {
- rtl92e_writeb(dev,
- rOFDM0_RxDetector3,
- priv->framesync);
+ rtl92e_writeb(dev, rOFDM0_RxDetector3,
+ priv->framesync);
reg_c38_State = RegC38_Default;
}
}
@@ -2129,14 +2126,14 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)
if (priv->frame_sync_monitor) {
if (priv->reset_count != reset_cnt) {
rtl92e_writeb(dev, rOFDM0_RxDetector3,
- priv->framesync);
+ priv->framesync);
reg_c38_State = RegC38_Default;
reset_cnt = priv->reset_count;
}
} else {
if (reg_c38_State) {
rtl92e_writeb(dev, rOFDM0_RxDetector3,
- priv->framesync);
+ priv->framesync);
reg_c38_State = RegC38_Default;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis
@ 2023-04-08 17:39 Sumitra Sharma
0 siblings, 0 replies; 4+ messages in thread
From: Sumitra Sharma @ 2023-04-08 17:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel
Fix alignment to match opening parenthesis as suggested by Linux
kernel coding-style. Check reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 31 +++++++++-----------
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 7506d7eb7b4c..1e16bfc9d52c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -285,7 +285,7 @@ static void _rtl92e_update_cap(struct net_device *dev, u16 cap)
u8 cur_slot_time = priv->slot_time;
if ((cap & WLAN_CAPABILITY_SHORT_SLOT_TIME) &&
- (!priv->rtllib->ht_info->current_rt2rt_long_slot_time)) {
+ (!priv->rtllib->ht_info->current_rt2rt_long_slot_time)) {
if (cur_slot_time != SHORT_SLOT_TIME) {
slot_time_val = SHORT_SLOT_TIME;
priv->rtllib->SetHwRegHandler(dev,
@@ -354,14 +354,12 @@ static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv,
return ret;
if (network->flags & NETWORK_HAS_QOS_MASK) {
- if (active_network &&
- (network->flags & NETWORK_HAS_QOS_PARAMETERS))
+ if (active_network && (network->flags & NETWORK_HAS_QOS_PARAMETERS))
network->qos_data.active = network->qos_data.supported;
if ((network->qos_data.active == 1) && (active_network == 1) &&
- (network->flags & NETWORK_HAS_QOS_PARAMETERS) &&
- (network->qos_data.old_param_count !=
- network->qos_data.param_count)) {
+ (network->flags & NETWORK_HAS_QOS_PARAMETERS) &&
+ (network->qos_data.old_param_count != network->qos_data.param_count)) {
network->qos_data.old_param_count =
network->qos_data.param_count;
priv->rtllib->wmm_acm = network->qos_data.wmm_acm;
@@ -423,7 +421,7 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv,
network->qos_data.param_count;
} else {
memcpy(&priv->rtllib->current_network.qos_data.parameters,
- &def_qos_parameters, size);
+ &def_qos_parameters, size);
priv->rtllib->current_network.qos_data.active = 0;
priv->rtllib->current_network.qos_data.supported = 0;
set_qos_param = 1;
@@ -439,8 +437,8 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv,
}
static int _rtl92e_handle_assoc_response(struct net_device *dev,
- struct rtllib_assoc_response_frame *resp,
- struct rtllib_network *network)
+ struct rtllib_assoc_response_frame *resp,
+ struct rtllib_network *network)
{
struct r8192_priv *priv = rtllib_priv(dev);
@@ -935,7 +933,7 @@ static short _rtl92e_is_tx_queue_empty(struct net_device *dev)
continue;
if (skb_queue_len(&(&priv->tx_ring[i])->queue) > 0) {
netdev_info(dev, "===>tx queue is not empty:%d, %d\n",
- i, skb_queue_len(&(&priv->tx_ring[i])->queue));
+ i, skb_queue_len(&(&priv->tx_ring[i])->queue));
return 0;
}
}
@@ -1213,7 +1211,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)
if ((ieee->state == RTLLIB_LINKED) && (ieee->iw_mode ==
IW_MODE_INFRA) && (!ieee->net_promiscuous_md)) {
if (ieee->link_detect_info.NumRxOkInPeriod > 100 ||
- ieee->link_detect_info.NumTxOkInPeriod > 100)
+ ieee->link_detect_info.NumTxOkInPeriod > 100)
bBusyTraffic = true;
if (ieee->link_detect_info.NumRxOkInPeriod > 4000 ||
@@ -1397,8 +1395,7 @@ static void _rtl92e_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
MAX_DEV_ADDR_SIZE);
u8 queue_index = tcb_desc->queue_index;
- if ((priv->rtllib->rf_power_state == rf_off) || !priv->up ||
- priv->reset_in_progress) {
+ if ((priv->rtllib->rf_power_state == rf_off) || !priv->up || priv->reset_in_progress) {
kfree_skb(skb);
return;
}
@@ -1431,7 +1428,7 @@ static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
if (queue_index != TXCMD_QUEUE) {
if ((priv->rtllib->rf_power_state == rf_off) ||
- !priv->up || priv->reset_in_progress) {
+ !priv->up || priv->reset_in_progress) {
kfree_skb(skb);
return 0;
}
@@ -1879,7 +1876,7 @@ static void _rtl92e_tx_resume(struct net_device *dev)
for (queue_index = BK_QUEUE;
queue_index < MAX_QUEUE_SIZE; queue_index++) {
while ((!skb_queue_empty(&ieee->skb_waitQ[queue_index])) &&
- (priv->rtllib->check_nic_enough_desc(dev, queue_index) > 0)) {
+ (priv->rtllib->check_nic_enough_desc(dev, queue_index) > 0)) {
skb = skb_dequeue(&ieee->skb_waitQ[queue_index]);
ieee->softmac_data_hard_start_xmit(skb, dev, 0);
}
@@ -1948,7 +1945,7 @@ static int _rtl92e_close(struct net_device *dev)
int ret;
if ((rtllib_act_scanning(priv->rtllib, false)) &&
- !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
+ !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
rtllib_stop_scan(priv->rtllib);
}
@@ -2272,7 +2269,7 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
if (dev->mem_start != 0) {
iounmap((void __iomem *)dev->mem_start);
release_mem_region(pci_resource_start(pdev, 1),
- pci_resource_len(pdev, 1));
+ pci_resource_len(pdev, 1));
}
free_rtllib(dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis
2023-04-08 16:51 [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis Sumitra Sharma
@ 2023-04-15 15:54 ` Greg Kroah-Hartman
2023-04-16 3:50 ` Sumitra Sharma
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-04-15 15:54 UTC (permalink / raw)
To: Sumitra Sharma; +Cc: linux-staging, linux-kernel
On Sat, Apr 08, 2023 at 09:51:51AM -0700, Sumitra Sharma wrote:
> Fix alignment to match opening parenthesis as suggested by Linux kernel
> coding-style. This issue is reported by checkpatch.
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
You have sent a lot of different patches for the same driver, with the
same subject line, but yet doing different things. I am totally
confused as to what is, and is not, the latest versions, so I am
dropping all of these from my review queue.
Please resend them all, as a numbered patch series, so that we have a
clue as to what to review here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis
2023-04-15 15:54 ` Greg Kroah-Hartman
@ 2023-04-16 3:50 ` Sumitra Sharma
0 siblings, 0 replies; 4+ messages in thread
From: Sumitra Sharma @ 2023-04-16 3:50 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel
On Sat, Apr 15, 2023 at 05:54:24PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 08, 2023 at 09:51:51AM -0700, Sumitra Sharma wrote:
> > Fix alignment to match opening parenthesis as suggested by Linux kernel
> > coding-style. This issue is reported by checkpatch.
> >
> > CHECK: Alignment should match open parenthesis
> >
> > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > ---
> > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
> > 1 file changed, 9 insertions(+), 12 deletions(-)
>
> You have sent a lot of different patches for the same driver, with the
> same subject line, but yet doing different things. I am totally
> confused as to what is, and is not, the latest versions, so I am
> dropping all of these from my review queue.
>
> Please resend them all, as a numbered patch series, so that we have a
> clue as to what to review here.
>
Okay. Thank you.
Regards
Sumitra
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-16 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-08 16:51 [PATCH] staging: rtl8192e: Fix alignment to match open parenthesis Sumitra Sharma
2023-04-15 15:54 ` Greg Kroah-Hartman
2023-04-16 3:50 ` Sumitra Sharma
-- strict thread matches above, loose matches on Subject: below --
2023-04-08 17:39 Sumitra Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).