* Re: [PATCH] staging: fbtft: fbtft-bus.c added params
2023-04-08 8:18 [PATCH] staging: fbtft: fbtft-bus.c added params Deepanshu Kartikey
@ 2023-04-08 8:22 ` Greg KH
2023-04-08 17:26 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2023-04-08 8:22 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: dri-devel, linux-fbdev, linux-staging, linux-kernel
On Sat, Apr 08, 2023 at 01:48:17PM +0530, Deepanshu Kartikey wrote:
> Added cpu_to_be16 param in define_fbtft_write_reg
>
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 3d422bc11641..228a5430c1d5 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out: \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> -define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, cpu_to_be16);
> +define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16);
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, cpu_to_be16);
>
> void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
> {
> --
> 2.25.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You sent multiple patches, yet no indication of which ones should be
applied in which order. Greg could just guess, but if you are
receiving this email, he guessed wrong and the patches didn't apply.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for a
description of how to do this so that Greg has a chance to apply these
correctly.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: fbtft: fbtft-bus.c added params
2023-04-08 8:18 [PATCH] staging: fbtft: fbtft-bus.c added params Deepanshu Kartikey
2023-04-08 8:22 ` Greg KH
@ 2023-04-08 17:26 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-04-08 17:26 UTC (permalink / raw)
To: Deepanshu Kartikey, gregkh
Cc: oe-kbuild-all, dri-devel, linux-fbdev, linux-staging,
linux-kernel, Deepanshu Kartikey
Hi Deepanshu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Deepanshu-Kartikey/staging-fbtft-fbtft-bus-c-added-params/20230408-161947
patch link: https://lore.kernel.org/r/20230408081817.81562-1-kartikey406%40gmail.com
patch subject: [PATCH] staging: fbtft: fbtft-bus.c added params
config: i386-randconfig-s001-20230403 (https://download.01.org/0day-ci/archive/20230409/202304090139.b8XZpHpu-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/038bedbb2c34ffc5e5ce77d5f49811778be8d631
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Deepanshu-Kartikey/staging-fbtft-fbtft-bus-c-added-params/20230408-161947
git checkout 038bedbb2c34ffc5e5ce77d5f49811778be8d631
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 olddefconfig
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/staging/fbtft/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304090139.b8XZpHpu-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: expected unsigned char [usertype]
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: got restricted __be16 [usertype]
>> drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: expected unsigned char [usertype]
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: got restricted __be16 [usertype]
>> drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: expected unsigned char [usertype]
drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: got restricted __be16 [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: expected unsigned short [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: got restricted __be16 [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: expected unsigned short [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: got restricted __be16 [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __be16 [usertype] @@
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: expected unsigned short [usertype]
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: got restricted __be16 [usertype]
vim +65 drivers/staging/fbtft/fbtft-bus.c
64
> 65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, cpu_to_be16);
66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16);
67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, cpu_to_be16);
68
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread