From: Stephan Snyman <rooiratel@tinyglitch.net>
To: gregkh@linuxfoundation.org
Cc: philipp.g.hortmann@gmail.com, kamrankhadijadj@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Stephan Snyman <rooiratel@tinyglitch.net>
Subject: [PATCH] staging: rtl8192e: add missing braces {}
Date: Thu, 20 Apr 2023 15:32:09 +0200 [thread overview]
Message-ID: <20230420133209.4661-1-rooiratel@tinyglitch.net> (raw)
Add missing braces to if/else statements to adhere to the
Linux kernel coding-style guidelines.
These issues were reported by checkpatch.pl
"CHECK: braces {} should be used on all arms of this statement"
Signed-off-by: Stephan Snyman <rooiratel@tinyglitch.net>
---
drivers/staging/rtl8192e/rtllib_rx.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index b649d02dc5c8..d44bf261de54 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -264,8 +264,9 @@ static int rtllib_is_eapol_frame(struct rtllib_device *ieee,
RTLLIB_FCTL_FROMDS &&
memcmp(hdr->addr1, dev->dev_addr, ETH_ALEN) == 0) {
/* FromDS frame with own addr as DA */
- } else
+ } else {
return 0;
+ }
if (skb->len < 24 + 8)
return 0;
@@ -433,8 +434,9 @@ static int is_duplicate_packet(struct rtllib_device *ieee,
if (*last_frag + 1 != frag)
/* out-of-order fragment */
goto drop;
- } else
+ } else {
*last_seq = seq;
+ }
*last_frag = frag;
*last_time = jiffies;
@@ -2314,8 +2316,9 @@ static inline int rtllib_network_init(
if (stats->freq == RTLLIB_52GHZ_BAND) {
/* for A band (No DS info) */
network->channel = stats->received_channel;
- } else
+ } else {
network->flags |= NETWORK_HAS_CCK;
+ }
network->wpa_ie_len = 0;
network->rsn_ie_len = 0;
@@ -2329,9 +2332,10 @@ static inline int rtllib_network_init(
return 1;
network->mode = 0;
- if (stats->freq == RTLLIB_52GHZ_BAND)
+
+ if (stats->freq == RTLLIB_52GHZ_BAND) {
network->mode = IEEE_A;
- else {
+ } else {
if (network->flags & NETWORK_HAS_OFDM)
network->mode |= IEEE_G;
if (network->flags & NETWORK_HAS_CCK)
--
2.40.0
next reply other threads:[~2023-04-20 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 13:32 Stephan Snyman [this message]
2023-04-21 5:19 ` [PATCH] staging: rtl8192e: add missing braces {} Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420133209.4661-1-rooiratel@tinyglitch.net \
--to=rooiratel@tinyglitch.net \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox