public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Kate Hsuan <hpa@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Cc: Kate Hsuan <hpa@redhat.com>
Subject: [PATCH 0/5] staging: media: atomisp: Remove #ifdef 2401
Date: Tue, 25 Apr 2023 15:48:36 +0800	[thread overview]
Message-ID: <20230425074841.29063-1-hpa@redhat.com> (raw)

Since #ifdef ISP2401 is used to determine the action of both models in compiler
time, we have to provide two binaries for both models. It is very unfriendly for
the users and for the package management aspect.

The proposed patch removed the #ifdef ISP2041 from the codes and made the 
path for both models can be determined at the runtime. Some of the #ifdef is 
highly integrated with functions and data structures. If we try to remove 
them, it will cause many issues, such as duplicated variable/function name
and data length. Therefore, these patches focus on removing the #ifdef
without affecting the change of structure.

Kate Hsuan (5):
  staging: media: atomisp: sh_css: Remove #ifdef ISP2401
  staging: media: atomisp: runtime: frame: remove #ifdef ISP2401
  staging: media: atomisp: sh_css_sp: Remove #ifdef ISP2401
  staging: media: atomisp: sh_css_firmware: determine firmware version
    at runtime
  staging: media: atomisp: sh_css_mipi: Remove #ifdef 2041

 .../atomisp/pci/runtime/frame/src/frame.c     |  15 +-
 drivers/staging/media/atomisp/pci/sh_css.c    | 584 +++++++++---------
 .../media/atomisp/pci/sh_css_firmware.c       |  18 +-
 .../staging/media/atomisp/pci/sh_css_mipi.c   | 101 ++-
 drivers/staging/media/atomisp/pci/sh_css_sp.c |  10 +-
 5 files changed, 359 insertions(+), 369 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-04-25  7:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  7:48 Kate Hsuan [this message]
2023-04-25  7:48 ` [PATCH 1/5] staging: media: atomisp: sh_css: Remove #ifdef ISP2401 Kate Hsuan
2023-04-26 11:25   ` Hans de Goede
2023-04-25  7:48 ` [PATCH 2/5] staging: media: atomisp: runtime: frame: remove " Kate Hsuan
2023-04-26 11:34   ` Hans de Goede
2023-04-25  7:48 ` [PATCH 3/5] staging: media: atomisp: sh_css_sp: Remove " Kate Hsuan
2023-04-26 12:08   ` Hans de Goede
2023-04-25  7:48 ` [PATCH 4/5] staging: media: atomisp: sh_css_firmware: determine firmware version at runtime Kate Hsuan
2023-04-26 12:08   ` Hans de Goede
2023-04-25  7:48 ` [PATCH 5/5] staging: media: atomisp: sh_css_mipi: Remove #ifdef 2041 Kate Hsuan
2023-04-26 12:16   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425074841.29063-1-hpa@redhat.com \
    --to=hpa@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox