From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD707E for ; Mon, 8 May 2023 06:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683527232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u+GKPljtf0bbm0Sf5mRrqhpg9XbqJkeZDiXckq915Y0=; b=dNJ2KTryhPNZS4kLh5sWhVFSNPkt1HCoXXmd5NMMMj6N7edHBl2POrQy1Y4ntRlZQNtESG RDDdc4KK3G4+6IvnZYib1DiU7mnjrhUEIFWDhBKPDqx4TaNTBCMJDgzDls40BvA7eBE2v+ 2mrhjkVgOkz6QoACuFRtUBVCdbpRdjQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-OoUHPfJmMnOgCQv8XPLGjg-1; Mon, 08 May 2023 02:27:09 -0400 X-MC-Unique: OoUHPfJmMnOgCQv8XPLGjg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2496B811E7C; Mon, 8 May 2023 06:27:09 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.67.24.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22776492C13; Mon, 8 May 2023 06:27:05 +0000 (UTC) From: Kate Hsuan To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Cc: Kate Hsuan Subject: [PATCH v2 3/5] staging: media: atomisp: sh_css_sp: Remove #ifdef ISP2401 Date: Mon, 8 May 2023 14:26:30 +0800 Message-Id: <20230508062632.34537-3-hpa@redhat.com> In-Reply-To: <20230508062632.34537-1-hpa@redhat.com> References: <20230508062632.34537-1-hpa@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 The actions of ISP2401 and 2400 will be determined at the runtime. Reviewed-by: Hans de Goede Signed-off-by: Kate Hsuan --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 0dd58a7fe2cc..297e1b981720 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -952,12 +952,10 @@ sh_css_sp_init_stage(struct ia_css_binary *binary, return 0; } -#if defined(ISP2401) - (void)continuous; - sh_css_sp_stage.deinterleaved = 0; -#else - sh_css_sp_stage.deinterleaved = ((stage == 0) && continuous); -#endif + if (IS_ISP2401) + sh_css_sp_stage.deinterleaved = 0; + else + sh_css_sp_stage.deinterleaved = ((stage == 0) && continuous); initialize_stage_frames(&sh_css_sp_stage.frames); /* -- 2.40.1