From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6030EBA56; Fri, 12 May 2023 11:23:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A07A0C433A8; Fri, 12 May 2023 11:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683890623; bh=LCee8NPgW5Z48oHs2X+4LDjkaisXA9d7iMkzZ/oL7EE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qawc5t5fo15Uxf3XH5wX4ydaoUgTaiH5Gxx8rNDVp/biF33zfq8hDHrcqmf5PcCRx h5D6KyvrhmHBnN7SoDNKMu4CspgF+DSO0P+kgN08ypYVZZ3jPJDU6Ka94a2pzGDJPb tn6BzE9cqryGUhjbkdQqBbBwgFOFgT0RJq0Y7/jo= Date: Fri, 12 May 2023 20:23:37 +0900 From: Greg Kroah-Hartman To: Bagas Sanjaya Cc: Linux SPDX Licenses , Linux DRI Development , Linux Kernel Mailing List , Linux Networking , Linux ARM , Linux Staging Drivers , Linux Watchdog Devices , Linux Kernel Actions , Diederik de Haas , Kate Stewart , Philippe Ombredanne , Thomas Gleixner , David Airlie , Karsten Keil , Jay Vosburgh , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sam Creasey , Dominik Brodowski , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Wim Van Sebroeck , Guenter Roeck , Jan Kara , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam Subject: Re: [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Message-ID: <2023051243-bunch-goliath-7380@gregkh> References: <20230512100620.36807-1-bagasdotme@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230512100620.36807-1-bagasdotme@gmail.com> On Fri, May 12, 2023 at 05:06:11PM +0700, Bagas Sanjaya wrote: > I trigger this patch series as a response to Didi's GPL full name fix > patches [1], for which all of them had been NAKed. In many cases, the > appropriate correction is to use SPDX license identifier instead. > > Often, when replacing license notice boilerplates with their equivalent > SPDX identifier, the notice doesn't mention explicit GPL version. Greg > [2] replied this question by falling back to GPL 1.0 (more precisely > GPL 1.0+ in order to be compatible with GPL 2.0 used by Linux kernel), > although there are exceptions (mostly resolved by inferring from > older patches covering similar situation). > > The series covers the same directories touched as Didi's ones, minus > Documentation/ (as should have been inferred by SPDX tags on respective > docs). > I'm glad to take these types of changes through the SPDX tree, but please break them up into smaller changes that show the justification for each type of change in each subsystem, so that we can evaluate them on an individual basis. As you did here, you are lumping things together only by the existance of the file in the tree, not by the logical type of change happening, which isn't ok. Also, you can send them as subsystem-specific series, so as to not have to cross-post all of the changes all over the place. I doubt the drm developers care about ethernet driver license issues :) thanks, greg k-h