Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

Greg Kroah-Hartman
2023-05-13T10:00:16Z

On Sat, May 13, 2023 at 11:48:51AM +0200, Pali Rohár wrote:
> On Friday 12 May 2023 17:06:20 Bagas Sanjaya wrote:
> > diff --git a/fs/udf/udftime.c b/fs/udf/udftime.c
> > index fce4ad976c8c29..d0fce5348fd3f3 100644
> > --- a/fs/udf/udftime.c
> > +++ b/fs/udf/udftime.c
> > @@ -1,21 +1,4 @@
> > -/* Copyright (C) 1993, 1994, 1995, 1996, 1997 Free Software Foundation, Inc.
> > - This file is part of the GNU C Library.
> > - Contributed by Paul Eggert (eggert@twinsun.com).
> > -
> > - The GNU C Library is free software; you can redistribute it and/or
> > - modify it under the terms of the GNU Library General Public License as
> > - published by the Free Software Foundation; either version 2 of the
> > - License, or (at your option) any later version.
> > -
> > - The GNU C Library is distributed in the hope that it will be useful,
> > - but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > - Library General Public License for more details.
> > -
> > - You should have received a copy of the GNU Library General Public
> > - License along with the GNU C Library; see the file COPYING.LIB. If not,
> > - write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> > - Boston, MA 02111-1307, USA. */
> > +// SPDX-License-Identifier: GPL-2.0-only
> >
> > /*
> > * dgb 10/02/98: ripped this from glibc source to help convert timestamps
>
> Please, dot not do this. It is really rude to people who worked on it in
> past (even if they do not care about this particular file anymore) as
> technically they still have ownership of this code / file. And such
> change never remove their ownership or copyright in most countries.
>

Yes, copyright lines should never be removed.

Bagas, I recommend taking the Linux Foundation "copyright and licensing"
online course before you respin this series. It's free online and might
help you in understanding some of the issues involved here and prevent
you from making these types of mistakes in the future.

thanks,

greg k-h