Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

Bagas Sanjaya
2023-05-13T09:31:20Z

On 5/12/23 20:21, Richard Fontana wrote:
> On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
>> diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
>> index de17a97e866742..b2b5bca45758df 100644
>> --- a/fs/udf/ecma_167.h
>> +++ b/fs/udf/ecma_167.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: BSD-2-Clause OR GPL-1.0+ */
>> /*
>> * ecma_167.h
>> *
>> @@ -8,29 +9,6 @@
>> * Copyright (c) 2017-2019 Pali Rohár <pali@kernel.org>
>> * All rights reserved.
>> *
>> - * Redistribution and use in source and binary forms, with or without
>> - * modification, are permitted provided that the following conditions
>> - * are met:
>> - * 1. Redistributions of source code must retain the above copyright
>> - * notice, this list of conditions, and the following disclaimer,
>> - * without modification.
>> - * 2. The name of the author may not be used to endorse or promote products
>> - * derived from this software without specific prior written permission.
>> - *
>
> This is not BSD-2-Clause. Ignoring the interior statement about the
> GPL, I think the closest SPDX identifier might be
> https://spdx.org/licenses/BSD-Source-Code.html
> but it doesn't quite match.
>

BSD-2-Clause but the second clause is the third one on BSD-3-Clause.
Weird...

>> diff --git a/fs/udf/udftime.c b/fs/udf/udftime.c
>> index fce4ad976c8c29..d0fce5348fd3f3 100644
>> --- a/fs/udf/udftime.c
>> +++ b/fs/udf/udftime.c
>> @@ -1,21 +1,4 @@
>> -/* Copyright (C) 1993, 1994, 1995, 1996, 1997 Free Software Foundation, Inc.
>> - This file is part of the GNU C Library.
>> - Contributed by Paul Eggert (eggert@twinsun.com).
>> -
>> - The GNU C Library is free software; you can redistribute it and/or
>> - modify it under the terms of the GNU Library General Public License as
>> - published by the Free Software Foundation; either version 2 of the
>> - License, or (at your option) any later version.
>> -
>> - The GNU C Library is distributed in the hope that it will be useful,
>> - but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> - Library General Public License for more details.
>> -
>> - You should have received a copy of the GNU Library General Public
>> - License along with the GNU C Library; see the file COPYING.LIB. If not,
>> - write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
>> - Boston, MA 02111-1307, USA. */
>> +// SPDX-License-Identifier: GPL-2.0-only
>
> Shouldn't this be
> // SPDX-License-Identifier: LGPL-2.0-or-later ?
> (or are you implicitly using the obscure LGPLv2.x section ... 3 mechanism?)
>

That's right. I missed the exact notice above when I submitted this
series.

Thanks.