* [PATCH] Staging: rts5208: rtsx: fixed unbalanced braces around else statement
@ 2023-05-14 6:49 Deepanshu Kartikey
2023-05-15 6:43 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Deepanshu Kartikey @ 2023-05-14 6:49 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Deepanshu Kartikey
Fixed unbalanced braces around else statement
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..0ab9355873f7 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ //we've got a command, let's do it!
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rts5208: rtsx: fixed unbalanced braces around else statement
2023-05-14 6:49 [PATCH] Staging: rts5208: rtsx: fixed unbalanced braces around else statement Deepanshu Kartikey
@ 2023-05-15 6:43 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-05-15 6:43 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: gregkh, linux-staging, linux-kernel
On Sun, May 14, 2023 at 12:19:36PM +0530, Deepanshu Kartikey wrote:
> Fixed unbalanced braces around else statement
>
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> ---
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..0ab9355873f7 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else {
> + //we've got a command, let's do it!
This is v2 of a patch. Here is my guide how to send a v2 patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: rts5208: rtsx: fixed unbalanced braces around else statement
@ 2023-05-19 3:12 Deepanshu Kartikey
0 siblings, 0 replies; 3+ messages in thread
From: Deepanshu Kartikey @ 2023-05-19 3:12 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, Deepanshu Kartikey
Fixed unbalanced braces around else statement
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-19 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-14 6:49 [PATCH] Staging: rts5208: rtsx: fixed unbalanced braces around else statement Deepanshu Kartikey
2023-05-15 6:43 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 3:12 Deepanshu Kartikey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox