From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00EB184F for ; Wed, 24 May 2023 06:01:30 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1hYi-00073O-TF; Wed, 24 May 2023 08:01:16 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q1hYX-002PqH-1c; Wed, 24 May 2023 08:01:05 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q1hYW-007SK3-Am; Wed, 24 May 2023 08:01:04 +0200 Date: Wed, 24 May 2023 08:01:04 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Hans de Goede , Greg Kroah-Hartman Cc: Crt Mori , linux-iio@vger.kernel.org, Tom Rix , Jon Nettleton , Peter Senna Tschudin , Christian Gromm , Jeremy Kerr , Jean Delvare , Marek =?utf-8?B?QmVow7pu?= , Lars-Peter Clausen , Haowen Bai , Jens Frederich , linux-staging@lists.linux.dev, Andy Shevchenko , Adrien Grassein , linux-media@vger.kernel.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Michael Hennerich , Kalle Valo , Menna Mahmoud , "Steven Rostedt (Google)" , Parthiban Veerasooran , Mauro Carvalho Chehab , kernel@pengutronix.de, Wolfram Sang , Sakari Ailus , Hans Verkuil , Peter Rosin , Jonathan Cameron Subject: Re: [PATCH] staging: Switch i2c drivers back to use .probe() Message-ID: <20230524060104.wljjqi2ep2ag2245@pengutronix.de> References: <20230523200036.465180-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zqy6b2uvxwwx5uuf" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-staging@lists.linux.dev --zqy6b2uvxwwx5uuf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Hans, On Tue, May 23, 2023 at 10:40:43PM +0200, Hans de Goede wrote: > On 5/23/23 22:00, Uwe Kleine-K=F6nig wrote: > > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > > call-back type"), all drivers being converted to .probe_new() and then > > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") conve= rt > > back to (the new) .probe() to be able to eventually drop .probe_new() f= rom > > struct i2c_driver. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > Hello, > >=20 > > this patch was generated using coccinelle. > >=20 > > I chose to convert all drivers below drivers/staging in a single > > patch, but if you prefer I can split by driver. >=20 > I'm currently doing a lot of cleanup work on the atomisp code > including the sensor drivers. Specifically I'm working on > removing drivers which are duplicate with the standard v4l2 > sensor drivers under drivers/media/i2c . So this patch is > likely to cause conflicts. >=20 > I have my own branch for my atomisp work from which I send > pull-reqs directly to Mauro Chehab: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=3D= media-atomisp >=20 > As such I think for the atomisp drivers it would be best if I directly > apply the atomisp bits of this patch (no need for a resend) to my > media-atomisp branch, is that ok with you ? For me that would be fine, it's mostly Greg who has to cope. As Jonathan also suggested to split, I suggest I do this. Then everyone can pickup the usual bits without too much conflicts. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --zqy6b2uvxwwx5uuf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmRtqB8ACgkQj4D7WH0S /k5jcAf/WFlyFOsuQCHCP7XhhLma9YjYqV09mCEayg0z2IjJ+7vSN3WRkhwspkEO ti62GhVpzLcGAMaZiPoB/4hZtJJfkjJrzfnOC0nhM7GnpBOorLWm0uV/Rih1O0pw dgXIp56Nk946bR2kjK4jFsezU5R8Be7iLRqF67E2ASL5HcI0ifC/kzyC3bIz3RXv HS6sE9oH2VO/Tumqt/D7DZCa3+JHwvkSY4tasd9/D1c1b0dvA+DPOh/DtfpGua5I WyTiA5R2KrzryD7aJUEuD4C8D66HiTahycCkemMtHwViEGTuTUvpkrStwAbC7rYB HwHePXvE1xRpNG0x3yAUWrd4Gs/gKg== =gQyv -----END PGP SIGNATURE----- --zqy6b2uvxwwx5uuf--