From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035A517E2 for ; Sun, 28 May 2023 09:13:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B2D2C433EF; Sun, 28 May 2023 09:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685265198; bh=X+wEkGcFPxyLRRStAYn+nV5CgUbOCpIYtQ2VqRZYruI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sz2PySYvXFdgPJGBwyCyzEzvDRi1So/HQhfyir6PYcl2zPP6aT1qyQVnrD1EKa3mW xULxaQ+2dpamAVCEiIiKSVwCJHERaXbkU+gAcpFMDQI6Z76QdChGWrpt8qnlX5Cpfj S8gDVdgYjzWO/lbzMry5w/kKn1KzuvtISSPmuQuo= Date: Sun, 28 May 2023 10:13:16 +0100 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Florian Fainelli , Stefan Wahren , Arnd Bergmann , Broadcom internal kernel review list , Umang Jain , Adrien Thierry , Phil Elwell , Peter Zijlstra , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: mark vchiq_platform_init() static Message-ID: <2023052856-tidal-trapdoor-1112@gregkh> References: <20230516202603.560554-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516202603.560554-1-arnd@kernel.org> On Tue, May 16, 2023 at 10:25:55PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This function has no callers from other files, and the declaration > was removed a while ago, causing a W=1 warning: > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for 'vchiq_platform_init' > > Marking it static solves this problem but introduces a new warning > since gcc determines that 'g_fragments_base' is never initialized > in some kernel configurations: > > In file included from include/linux/string.h:254, > from include/linux/bitmap.h:11, > from include/linux/cpumask.h:12, > from include/linux/mm_types_task.h:14, > from include/linux/mm_types.h:5, > from include/linux/buildid.h:5, > from include/linux/module.h:14, > from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8: > In function 'memcpy_to_page', > inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:433:4: > include/linux/fortify-string.h:57:33: error: argument 2 null where non-null expected [-Werror=nonnull] > include/linux/highmem.h:427:9: note: in expansion of macro 'memcpy' > 427 | memcpy(to + offset, from, len); > | ^~~~~~ > > Add a NULL pointer check for this in addition to the static annotation > to avoid both. > > Fixes: 89cc4218f640 ("staging: vchiq_arm: drop unnecessary declarations") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Nice, thanks for finally fixing this up, it's been a low-grade annoyance for a very long time. greg k-h