Re: [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode

Dan Carpenter
2023-06-07T15:07:28Z

On Wed, Jun 07, 2023 at 08:31:41PM +0530, Yogesh Hegde wrote:
> The variable SetWirelessMode is set in only one place throughout the
> driver. This patch removes the variable and calls the real function
> directly instead, eliminating the unnecessary indirection.
> Additionally, the removal of the variable aligns with the checkpatch
> guidelines by removing the use of CamelCase.
>
> Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com>
> ---
>
> v2: Removed the variable and called the function direction instead of
> just renaming the variable as suggested by Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter