From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yogesh Hegde <yogi.kernel@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Trivial code cleanup patches
Date: Thu, 15 Jun 2023 12:36:45 +0200 [thread overview]
Message-ID: <2023061532-fall-earthy-c429@gregkh> (raw)
In-Reply-To: <cover.1686149467.git.yogi.kernel@gmail.com>
On Wed, Jun 07, 2023 at 08:31:19PM +0530, Yogesh Hegde wrote:
> These patches remove variables in the struct rtllib_device that were
> set only once throughout the driver. Instead of using these variables,
> the patches modify the relevant code to directly call the corresponding
> functions, eliminating unnecessary indirection and removing CamelCase.
> The patches are required to be applied in sequence.
>
> Yogesh Hegde (5):
> staging: rtl8192e: Remove variable SetWirelessMode
> staging: rtl8192e: Remove variable SetBWModeHandler
> staging: rtl8192e: Remove variable LeisurePSLeave
> staging: rtl8192e: Remove variable InitialGainHandler
> staging: rtl8192e: Remove DRV_NAME definition in rtllib_debug.h
>
> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++--
> drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ----
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++----
> drivers/staging/rtl8192e/rtllib.h | 6 ------
> drivers/staging/rtl8192e/rtllib_debug.h | 5 -----
> drivers/staging/rtl8192e/rtllib_rx.c | 3 ++-
> drivers/staging/rtl8192e/rtllib_softmac.c | 16 +++++++---------
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 9 +++++----
> 8 files changed, 20 insertions(+), 35 deletions(-)
>
> --
> 2.25.1
>
>
These break the build, as reported by the test robot, please fix up.
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-15 10:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:01 [PATCH v2 0/5] Trivial code cleanup patches Yogesh Hegde
2023-06-07 15:01 ` [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode Yogesh Hegde
2023-06-07 15:07 ` Dan Carpenter
2023-06-07 20:18 ` Philipp Hortmann
2023-06-08 9:00 ` Dan Carpenter
2023-06-08 9:59 ` Yogesh Hegde
2023-06-08 10:27 ` Dan Carpenter
2023-06-08 12:43 ` Philipp Hortmann
2023-06-12 1:52 ` kernel test robot
2023-06-07 15:02 ` [PATCH v2 2/5] staging: rtl8192e: Remove variable SetBWModeHandler Yogesh Hegde
2023-06-13 9:16 ` kernel test robot
2023-06-07 15:02 ` [PATCH v2 3/5] staging: rtl8192e: Remove variable LeisurePSLeave Yogesh Hegde
2023-06-07 15:02 ` [PATCH v2 4/5] staging: rtl8192e: Remove variable InitialGainHandler Yogesh Hegde
2023-06-07 15:03 ` [PATCH v2 5/5] staging: rtl8192e: Remove DRV_NAME definition in rtllib_debug.h Yogesh Hegde
2023-06-07 15:10 ` [PATCH v2 0/5] Trivial code cleanup patches Dan Carpenter
2023-06-15 10:36 ` Greg Kroah-Hartman [this message]
2023-06-15 14:09 ` Yogesh Hegde
2023-06-15 14:34 ` Greg Kroah-Hartman
2023-06-15 16:11 ` Yogesh Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061532-fall-earthy-c429@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox