* [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
@ 2022-12-21 7:40 Umang Jain
2022-12-21 11:34 ` Stefan Wahren
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Umang Jain @ 2022-12-21 7:40 UTC (permalink / raw)
To: linux-kernel, linux-staging, linux-rpi-kernel, linux-arm-kernel
Cc: Greg Kroah-Hartman, Adrien Thierry, Stefan Wahren, Kieran Bingham,
Laurent Pinchart, Umang Jain
Additional declaration of struct vchiq_instance was introduced in the
commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
service callbacks"). Drop the extra declaration.
Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
index 66965da11443..52e106f117da 100644
--- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
+++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
@@ -78,8 +78,6 @@ struct vchiq_service_params_kernel {
short version_min; /* Update for incompatible changes */
};
-struct vchiq_instance;
-
extern int vchiq_initialise(struct vchiq_instance **pinstance);
extern int vchiq_shutdown(struct vchiq_instance *instance);
extern int vchiq_connect(struct vchiq_instance *instance);
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
2022-12-21 7:40 [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration Umang Jain
@ 2022-12-21 11:34 ` Stefan Wahren
2022-12-21 12:33 ` Kieran Bingham
2023-06-20 13:46 ` Umang Jain
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Wahren @ 2022-12-21 11:34 UTC (permalink / raw)
To: Umang Jain, linux-kernel, linux-staging, linux-rpi-kernel,
linux-arm-kernel
Cc: Greg Kroah-Hartman, Adrien Thierry, Kieran Bingham,
Laurent Pinchart
Am 21.12.22 um 08:40 schrieb Umang Jain:
> Additional declaration of struct vchiq_instance was introduced in the
> commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
> service callbacks"). Drop the extra declaration.
>
> Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
2022-12-21 7:40 [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration Umang Jain
2022-12-21 11:34 ` Stefan Wahren
@ 2022-12-21 12:33 ` Kieran Bingham
2023-06-20 13:46 ` Umang Jain
2 siblings, 0 replies; 5+ messages in thread
From: Kieran Bingham @ 2022-12-21 12:33 UTC (permalink / raw)
To: Umang Jain, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-staging
Cc: Greg Kroah-Hartman, Adrien Thierry, Stefan Wahren,
Laurent Pinchart, Umang Jain
Quoting Umang Jain (2022-12-21 07:40:47)
> Additional declaration of struct vchiq_instance was introduced in the
> commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
> service callbacks"). Drop the extra declaration.
>
> Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
It's tempting to move the other instance up to near the top of the file
too, but not necessary.
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> index 66965da11443..52e106f117da 100644
> --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel {
> short version_min; /* Update for incompatible changes */
> };
>
> -struct vchiq_instance;
> -
> extern int vchiq_initialise(struct vchiq_instance **pinstance);
> extern int vchiq_shutdown(struct vchiq_instance *instance);
> extern int vchiq_connect(struct vchiq_instance *instance);
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
2022-12-21 7:40 [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration Umang Jain
2022-12-21 11:34 ` Stefan Wahren
2022-12-21 12:33 ` Kieran Bingham
@ 2023-06-20 13:46 ` Umang Jain
2023-06-20 14:11 ` Greg Kroah-Hartman
2 siblings, 1 reply; 5+ messages in thread
From: Umang Jain @ 2023-06-20 13:46 UTC (permalink / raw)
To: linux-kernel, linux-staging, linux-rpi-kernel, linux-arm-kernel
Cc: Greg Kroah-Hartman, Adrien Thierry, Stefan Wahren, Kieran Bingham,
Laurent Pinchart
Hi again,
Can this be collected please?. The series has two R-b tags and I think
it got skipped during the last window?
On 12/21/22 1:10 PM, Umang Jain wrote:
> Additional declaration of struct vchiq_instance was introduced in the
> commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
> service callbacks"). Drop the extra declaration.
>
> Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> index 66965da11443..52e106f117da 100644
> --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel {
> short version_min; /* Update for incompatible changes */
> };
>
> -struct vchiq_instance;
> -
> extern int vchiq_initialise(struct vchiq_instance **pinstance);
> extern int vchiq_shutdown(struct vchiq_instance *instance);
> extern int vchiq_connect(struct vchiq_instance *instance);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
2023-06-20 13:46 ` Umang Jain
@ 2023-06-20 14:11 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2023-06-20 14:11 UTC (permalink / raw)
To: Umang Jain
Cc: linux-kernel, linux-staging, linux-rpi-kernel, linux-arm-kernel,
Adrien Thierry, Stefan Wahren, Kieran Bingham, Laurent Pinchart
On Tue, Jun 20, 2023 at 07:16:15PM +0530, Umang Jain wrote:
> Hi again,
>
> Can this be collected please?. The series has two R-b tags and I think it
> got skipped during the last window?
SOrry for the delay, this got dropped somewhere, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-20 14:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-21 7:40 [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration Umang Jain
2022-12-21 11:34 ` Stefan Wahren
2022-12-21 12:33 ` Kieran Bingham
2023-06-20 13:46 ` Umang Jain
2023-06-20 14:11 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).