Re: [PATCH 00/12] arch,fbdev: Move screen_info into arch/

Arnd Bergmann
2023-06-29T14:29:40Z

On Thu, Jun 29, 2023, at 15:31, Arnd Bergmann wrote:
> On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote:
>>
>> Future directions: with the patchset in place, it will become possible
>> to provide screen_info and edid_info only if there are users. Some
>> architectures do this by testing for CONFIG_VT, CONFIG_DUMMY_CONSOLE,
>> etc. A more uniform approach would be nice. We should also attempt
>> to minimize access to the global screen_info as much as possible. To
>> do so, some drivers, such as efifb and vesafb, would require an update.
>> The firmware's EDID data could possibly made available outside of fbdev.
>> For example, the simpledrm and ofdrm drivers could provide such data
>> to userspace compositors.
>
> I suspect that most architectures that provide a screen_info only
> have this in order to compile the framebuffer drivers, and provide
> hardcoded data that does not even reflect any real hardware.
>
> We can probably reduce the number of architectures that do this
> a lot, especially if we get EFI out of the picture.

I tried to have another look at who uses what, and here are
some observations:

- EFIFB and hyperv are the only ones that are relevant on modern
systmes, and they are only used on systems using EFI, so they
could use a separate data structure that is defined as part of
drivers/firmware/efi. This would likely mean we don't have to
define a separate screen_info for arm64, loongarch, ia64 and
riscv, and could separate the legacy vgacon/vesafb stuff on
arm32 from the efi side.

- FB_SIS can likely be marked 'depends on X86' like FB_INTEL,
it seems to depend on x86 BOOT_VESA_SUPPORT.

- FB_VGA16 is currently support on powerpc and enabled on
one defconfig (pasemi), which I'm fairly sure is a mistake,
so this could be made x86 specific as well.

- VGA_CONSOLE has a complicated Kconfig dependency list that
lists platforms without VGA support but I think this is better
expressed with a positive list. It looks like csky, hexagon,
nios2 and xtensa should be excluded here and not provide
screen_info.

- arm and mips only need to provide screen_info on machines
with VGA_CONSOLE. On Arm we have a dependency on
footbridge/integrator/netwinder, while on mips the
dependency can be added to the platforms that fill
the info (mips, malta, sibyte, sni).

- DUMMY_CONSOLE only uses screen_info on arm, and this should
likely be limited to the three obsolete machines that
support VGACON. Almost all Arm machines use DT these days
and won't ever fill the screen info dynamically.

Arnd