From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhang Shurong <zhang_shurong@foxmail.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <error27@gmail.com>, Xu Panda <xu.panda@zte.com.cn>
Subject: Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Date: Mon, 10 Jul 2023 07:47:04 +0200 [thread overview]
Message-ID: <2023071056-amused-yam-5e29@gregkh> (raw)
In-Reply-To: <tencent_BB4124566E846A2FB6ECC0F63C5A15BE5009@qq.com>
On Mon, Jul 10, 2023 at 01:41:07PM +0800, Zhang Shurong wrote:
> Hi Markus,
>
> > 2023年7月10日 03:56，Markus Elfring <Markus.Elfring@web.de> 写道：
> >
> >>>> The "exc->key_len" is a u16 that comes from the user. If it's over
> >>>> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
> >>>
> >>> Please choose an imperative change suggestion.
> >>
> >> Please stop reviewing staging patches, it is not helpful for anyone.
> >
> > It seems that further contributors need to become more aware about
> > (and finally adhere to) requirements from the Linux development documentation.
> >
> > Regards,
> > Markus
>
> I'm guilty of my incorrect patch format. And do I need to write another
> patch to fix this format issue?
One of the hardest things in kernel development is learning what
reviews, and what reviewers, should be ignored. This is one of them :)
No need to change the patch yet, let me get to this change this week and
I'll let you know.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-10 5:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 5:50 [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext() Zhang Shurong
2023-07-09 19:21 ` Markus Elfring
2023-07-09 19:42 ` Greg Kroah-Hartman
2023-07-09 19:56 ` Markus Elfring
2023-07-10 5:41 ` Zhang Shurong
2023-07-10 5:47 ` Greg Kroah-Hartman [this message]
2023-07-10 6:32 ` Markus Elfring
2023-07-10 6:21 ` Markus Elfring
2023-07-10 6:08 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071056-amused-yam-5e29@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xu.panda@zte.com.cn \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox